Skip to content

Add BAL SmartFactor example#2449

Merged
dellaert merged 1 commit intoborglab:developfrom
dvorak0:smartfactor-bal
Mar 8, 2026
Merged

Add BAL SmartFactor example#2449
dellaert merged 1 commit intoborglab:developfrom
dvorak0:smartfactor-bal

Conversation

@dvorak0
Copy link
Copy Markdown
Contributor

@dvorak0 dvorak0 commented Mar 5, 2026

Summary:

  • Add examples/SFMExample_SmartFactor_bal.cpp.
  • It is a BAL-input version of SFMExample_SmartFactor.cpp:
    • reads data with SfmData::FromBalFile
    • builds SmartProjectionFactor graph
    • adds two camera priors to fix gauge/scale
    • runs LM and prints final error + iterations
  • Goal: enable direct SmartFactor testing on BAL datasets (comparable to SFMExample_bal).

@dvorak0
Copy link
Copy Markdown
Contributor Author

dvorak0 commented Mar 5, 2026

@dellaert hi prof. frank, could you have a look at this?

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@dellaert dellaert merged commit 6b076f1 into borglab:develop Mar 8, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants