Wrap DCSAM class and remove hybrid examples#2454
Draft
varunagrawal wants to merge 1 commit intodevelopfrom
Draft
Wrap DCSAM class and remove hybrid examples#2454varunagrawal wants to merge 1 commit intodevelopfrom
varunagrawal wants to merge 1 commit intodevelopfrom
Conversation
Member
|
Would be nice to still have a python notebook showcasing hybrid inference |
dellaert
approved these changes
Mar 9, 2026
Member
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
Would love a notebook for hybrid and a test for DCSAM
| #include <gtsam/hybrid/DCSAM.h> | ||
| #include <gtsam/nonlinear/ISAM2Params.h> | ||
|
|
||
| class DCSAM { |
Member
|
@copilot please make a PR to
|
Contributor
Contributor
Author
|
@dellaert I would prefer not to have AI involved in this. I am focused on finishing the hybrid paper and then I can switch back to this and land the requested changes. :) |
Member
|
It’s just additive. You did not add a test, it’s now there. You did not add a notebook, it’s now there. I’d prefer to have those. |
Contributor
Author
|
Yes that is on my radar. I first need to finish the hybrid stuff so we can submit that. :) |
Member
|
This is now 3 weeks old. Considering merging the AI tests and notebook and cleaning up to your taste. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have moved all the hybrid examples to https://github.com/varunagrawal/hybrid-factor-graph-examples/ following the same pattern as https://github.com/MarineRoboticsGroup/dcsam-examples.