Fix tMin_ reset when an iteration has zero duration#2464
Merged
dellaert merged 1 commit intoborglab:developfrom Mar 13, 2026
Merged
Fix tMin_ reset when an iteration has zero duration#2464dellaert merged 1 commit intoborglab:developfrom
dellaert merged 1 commit intoborglab:developfrom
Conversation
tMin_ was initialized to 0 and the finishedIteration() check used tMin_ == 0 as a proxy for 'first iteration'. This caused tMin_ to reset whenever an iteration legitimately completed in 0 microseconds, producing incorrect minimum timing statistics. Initialize tMin_ to std::numeric_limits<size_t>::max() so that any real timing value is smaller, and simplify the comparison. Fixes borglab#1636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimingOutline::tMin_is initialized to 0, andfinishedIteration()usestMin_ == 0as a proxy for "first iteration". This means any iteration that legitimately completes in 0 microseconds causestMin_to keep resetting, producing incorrect minimum timing statistics.Fix: initialize
tMin_tostd::numeric_limits<size_t>::max()so any real measurement is naturally smaller, and simplify the comparison infinishedIteration().Fixes #1636