Adding additional logging to express why an exception is happening. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for the cloud event `from_http` method to throw a variety of error messages (which you can't debug because the exception is swallowed by this try/catch or method). This should extend a error to the user on why exactly 'No CloudEvent available' is happening.
|
/approve |
sferich888
added a commit
to sferich888/parliament
that referenced
this pull request
Feb 9, 2024
Tests for boson-project#26 are failing. Following https://stackoverflow.com/questions/77213053/why-did-flask-start-failing-with-importerror-cannot-import-name-url-quote-fr this should address the dependency issues.
matejvasek
pushed a commit
that referenced
this pull request
Feb 9, 2024
Tests for #26 are failing. Following https://stackoverflow.com/questions/77213053/why-did-flask-start-failing-with-importerror-cannot-import-name-url-quote-fr this should address the dependency issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the cloud event
from_httpmethod to throw a variety of error messages (which you can't debug because the exception is swallowed by this try/catch or method).This should extend a error to the user on why exactly 'No CloudEvent available' is happening.