docs: remove OCI consideration from BUILDING.md #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twoliter now handles OCI fetching internally -- there is no need for builders to consider the OCI toolchain.
bcressey
approved these changes
Aug 11, 2025
|
We'll need a similar change over in the kernel kit. |
jmt-lab
reviewed
Aug 11, 2025
|
|
||
| We recommend using `crane` (and `krane`) over `docker` as it has shown better performance in our testing. | ||
|
|
||
| #### Docker |
There was a problem hiding this comment.
I can get the above, is there a reason we are removing the docker part entirely, like i don't think we need the daemon.json anymore due to modern docker and our move to krane but docker is still a build requirement that is needed.
koooosh
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #591
Description of changes:
Twoliter now handles OCI fetching internally -- there is no need for builders to consider the OCI toolchain.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.