Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Always run brave ads on iOS if ShouldAlwaysRunBraveAdsService true #22008

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Feb 12, 2024

Added ability to start Brave Ads service if ShouldAlwaysRunBraveAdsService feature is true when Brave Rewards is disabled. ShouldAlwaysRunBraveAdsService feature is disabled by default.

Resolves brave/brave-browser#35520

The PR has been reviewed in brave-ios repo here: brave/brave-ios#8699

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

ShouldAlwaysRunBraveAdsService feature DISABLED

Test case 1:

  • Fresh install
  • Launch browser
    • EXPECTED RESULT: Ads service is not started

Test case 2:

  • Fresh install
  • Launch browser
  • Join Brave Rewards
    • EXPECTED RESULT: Ads service is started
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started
  • Disable Brave Rewards
    • EXPECTED RESULT: Ads service is stopped
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is not started

Test case 3:

  • Fresh install
  • Launch browser
  • Join Brave News
    • EXPECTED RESULT: Ads service is started
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started
  • Disable Brave News
    • EXPECTED RESULT: Ads service is stopped
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is not started

ShouldAlwaysRunBraveAdsService feature ENABLED

Test case 1:

  • Fresh install
    • EXPECTED RESULT: Ads service is started
  • Launch browser
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started

Test case 2:

  • Fresh install
  • Launch browser
    • EXPECTED RESULT: Ads service is started
  • Join Brave Rewards
    • EXPECTED RESULT: Ads service should not be restarted
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started
  • Disable Brave Rewards
    • EXPECTED RESULT: Ads service should not stop
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started

Test case 3:

  • Fresh install
  • Launch browser
    • EXPECTED RESULT: Ads service is started
  • Join Brave News
    • EXPECTED RESULT: Ads service should not be restarted
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started
  • Disable Brave News
    • EXPECTED RESULT: Ads service should not stop
  • Quit browser
  • Launch browser
    • EXPECTED RESULT: Ads service is started

@kylehickinson
Copy link
Collaborator

Can you please add detail to brave/brave-browser#35520

@aseren aseren merged commit eb622ec into master Feb 13, 2024
20 checks passed
@aseren aseren deleted the issues/35520_ios branch February 13, 2024 18:03
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Unify iOS kShouldAlwaysRunBraveAdsServiceFeature
3 participants