Add the option to subtract histograms to the merge_histogram function#793
Merged
mike-w-wilson merged 12 commits intomainfrom Jul 31, 2025
Merged
Add the option to subtract histograms to the merge_histogram function#793mike-w-wilson merged 12 commits intomainfrom
mike-w-wilson merged 12 commits intomainfrom
Conversation
ch-kr
reviewed
Jul 28, 2025
Contributor
ch-kr
left a comment
ch-kr
left a comment
There was a problem hiding this comment.
thanks for adding! one docstring suggestion I forgot to add as a commit and a minor code refactoring suggestion
Contributor
Author
|
Back to you, @ch-kr -- I refactored again. I agree on putting the negative value handling into a private function but I found it a bit confusing that we were |
ch-kr
reviewed
Jul 31, 2025
Contributor
ch-kr
left a comment
ch-kr
left a comment
There was a problem hiding this comment.
I removed the if and added a couple extra tests -- I think this is good to go afterwards
mike-w-wilson
commented
Jul 31, 2025
ch-kr
approved these changes
Jul 31, 2025
Co-authored-by: Katherine Chao <kchao@broadinstitute.org>
Co-authored-by: Mike Wilson <mwilson@broadinstitute.org>
mike-w-wilson
force-pushed
the
mw/merge_hist_diff
branch
from
cb1f90a to
526d2fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option to subtract histograms in the merge_histograms function as well as tests for the entire function