ID-1174 Add combined user state api call to reduce needed ui api calls #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docker/run-postgres.sh
Ghost-in-a-Jar
commented
May 17, 2024
| Set.empty, | ||
| includePublic = false, | ||
| samRequestContext | ||
| ) |
There was a problem hiding this comment.
I matched this with the call that the ui is doing
Ghost-in-a-Jar
commented
May 17, 2024
| @@ -27,6 +27,8 @@ class MockSamRoutesBuilder(allUsersGroup: WorkbenchGroup)(implicit system: Actor | |||
| private val userServiceBuilder: MockUserServiceBuilder = MockUserServiceBuilder() | |||
| private val mockTosServiceBuilder = MockTosServiceBuilder() | |||
|
|
|||
| val mockResourceService = mock[ResourceService] | |||
There was a problem hiding this comment.
I didnt want to have to add a whole MockResourceServiceBuilder thing just for this so I made this mock available for mocking in the test i wrote
Shakespeared
approved these changes
May 17, 2024
1 task
Ghost-in-a-Jar
force-pushed
the
ID-1174-combined-user-state-api
branch
from
803bc72 to
ae94eb9
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combined-user-state-api
branch
from
ae94eb9 to
e091b55
Compare
samanehsan
approved these changes
May 21, 2024
Ghost-in-a-Jar
force-pushed
the
ID-1174-combined-user-state-api
branch
2 times, most recently
from
c2b738f to
a9475cf
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combined-user-state-api
branch
from
07d63dc to
5911109
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1174
What:
Adds a combined user state api call in order to reduce the amount of api calls needed from the ui to sam in order to load user state.
Why:
Right now, Terra-UI makes 5 calls at once to Sam to get user information. This led to a recent incident where we added a call to Sam from Terra-UI on login, but forgot to tell Sam to ignore the ToS acceptance for that call.
In general, Terra-UI is very chatty with Terra APIs. This leads to an increased risk of call failure. This new endpoint will make the UI less error-prone in its communication with Sam, as well as simplify the login code in the UI.
How:
I added a new api endpoint that returns the user's samUser, allowances, attributes, terms of service details, and enterprise features.
These are all to replace the multiple api calls in the ui here with a single call.
PR checklist