Repository navigation
feat(currency): add Vietnamese Dong (VND) - #151
Closed
tnt1232007 wants to merge 1 commit into
Closed
tnt1232007 wants to merge 1 commit into
tnt1232007 wants to merge 1 commit into
Conversation
Add VND to the built-in currency list and map the ₫ symbol in the Wallos importer so VND subscriptions keep their currency on import. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks @tnt1232007 for the addition |
This was referenced Oct 16, 2026
Owner
|
Thanks @tnt1232007! This is included in the v0.6.9 release PR, #153, with your commit kept as is. Closing here in favour of that PR. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Vietnamese Dong to the built-in currency list. VND is a supported symbol at Fixer.io, so conversion works the same as for the other currencies.
Changes:
internal/service/currency.go: append{Code: "VND", Symbol: "₫", Name: "Vietnamese Dong"}toBuiltinCurrencies.internal/service/currency_test.go: update the last-entry assertion fromUAHtoVND.internal/service/wallos_import.go: map₫toVNDinsymbolToCurrency.₫is used only by VND, so a Wallos export with VND subscriptions keeps its currency instead of falling back to the instance default.Tested with Go 1.24.13 (linux/amd64):
go mod verify,go build, andgo test ./...pass;gofmt -lis clean on the changed files.🤖 Generated with Claude Code