Skip to content

v0.6.9 - Vietnamese Dong and currency formatting - #153

Merged
bscott merged 6 commits into
mainfrom
auto/adoring-fermat-d8uzgh
Oct 18, 2026
Merged

bscott merged 6 commits into
mainfrom
auto/adoring-fermat-d8uzgh

Conversation

@bscott

@bscott bscott commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Vietnamese Dong (VND, ₫), merged from feat(currency): add Vietnamese Dong (VND) #151 by @tnt1232007 with its commit and authorship preserved.
  • Show amounts in currencies without a minor unit (VND, JPY, KRW) as whole numbers across the UI, calendar, iCal export and notifications.
  • Wallos import: parse grouped thousands and trailing currency symbols (100.000 ₫, 1.000.000 ₫, 9,99 €).
  • Calendar test: fixed UTC renewal date, and iCal assertions scoped to the cancel-by event.

Test Plan

  • go build ./... && go vet ./... && go test ./...
  • Calendar tests pass under UTC, America/Los_Angeles, Pacific/Kiritimati and Pacific/Pago_Pago
  • Smoke test with VND as the default currency: dashboard, analytics, subscription list, calendar and iCal show whole-dong amounts; USD keeps 2 decimals
  • Chromium Playwright suite: 35/43 pass; the same 8 tests also fail on main in this environment

Closes #151
Closes #152
Closes #148
Closes #149


Generated by Claude Code

tnt1232007 and others added 6 commits October 10, 2026 11:27
Add VND to the built-in currency list and map the ₫ symbol in the Wallos
importer so VND subscriptions keep their currency on import.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Amounts were always formatted with two decimals, so currencies without
a minor unit (VND, JPY, KRW) rendered as e.g. "₫220000.00".

- Add service.CurrencyDecimals and service.FormatAmount, treating the
  ISO 4217 zero-decimal currencies JPY, KRW and VND as whole numbers
- Register a formatAmount template function and use it on the
  dashboard, analytics and subscription list
- Expose the currency's decimals to the calendar view
- Use the currency-aware formatting in iCal descriptions, email,
  Pushover, Telegram and webhook notifications
…rices

Fixes #152.

- Detect the currency symbol after the amount ("100.000 ₫", "9,99 €")
  when none precedes it
- Treat repeated "." or "," separators as thousands grouping
  ("1.000.000 ₫", "$1,234,567")
- For zero-decimal currencies (VND, JPY, KRW), treat a single separator
  followed by exactly three digits as grouping ("₫ 100.000")

Wallos itself exports the symbol followed by the raw stored number
("₫100000"), which parses exactly as before; the new rules only apply to
hand-edited or reformatted prices.
Fixes #148, fixes #149.

- Use a fixed UTC renewal timestamp so calendar and iCal date assertions
  don't depend on the machine's timezone or the current date
- Find the cancel-by VEVENT by its subtrackr-cancelby- UID and assert its
  full DTSTART and SUMMARY within that event
A price like "₩0.125" has a zero integer part, so three trailing digits
there are fraction digits rather than thousands grouping.
@claude

claude Bot commented Oct 18, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@bscott
bscott merged commit fcd9648 into main Oct 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants