Repository navigation
v0.6.9 - Vietnamese Dong and currency formatting - #153
Merged
Merged
Conversation
Add VND to the built-in currency list and map the ₫ symbol in the Wallos importer so VND subscriptions keep their currency on import. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Amounts were always formatted with two decimals, so currencies without a minor unit (VND, JPY, KRW) rendered as e.g. "₫220000.00". - Add service.CurrencyDecimals and service.FormatAmount, treating the ISO 4217 zero-decimal currencies JPY, KRW and VND as whole numbers - Register a formatAmount template function and use it on the dashboard, analytics and subscription list - Expose the currency's decimals to the calendar view - Use the currency-aware formatting in iCal descriptions, email, Pushover, Telegram and webhook notifications
…rices Fixes #152. - Detect the currency symbol after the amount ("100.000 ₫", "9,99 €") when none precedes it - Treat repeated "." or "," separators as thousands grouping ("1.000.000 ₫", "$1,234,567") - For zero-decimal currencies (VND, JPY, KRW), treat a single separator followed by exactly three digits as grouping ("₫ 100.000") Wallos itself exports the symbol followed by the raw stored number ("₫100000"), which parses exactly as before; the new rules only apply to hand-edited or reformatted prices.
A price like "₩0.125" has a zero integer part, so three trailing digits there are fraction digits rather than thousands grouping.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
100.000 ₫,1.000.000 ₫,9,99 €).Test Plan
go build ./... && go vet ./... && go test ./...mainin this environmentCloses #151
Closes #152
Closes #148
Closes #149
Generated by Claude Code