Add cmake version - #173
Merged
Merged
Conversation
7 tasks
Owner
|
Hi, thanks for the PR! This seems fine (after some amount of reading up about what these stuff do). |
btzy
approved these changes
Dec 4, 2025
btzy
left a comment
btzy
left a comment
Owner
There was a problem hiding this comment.
Do you know why this wasn't needed by vcpkg before?
Contributor
Author
|
It's actually to be compatible with CPM in combination with vcpkg. There are projects that are use CPM and to make them compatible with vcpkg they need the version in cmake |
Tom94
pushed a commit
to mitsuba-renderer/nativefiledialog-extended
that referenced
this pull request
Jun 29, 2026
The version file specifies that releases with the same major version are backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.