testbazel: load sh_binary / sh_test from @rules_shell (prep for Bazel 9)#11996
Merged
dan-stowell merged 2 commits intomasterfrom Apr 24, 2026
Merged
testbazel: load sh_binary / sh_test from @rules_shell (prep for Bazel 9)#11996dan-stowell merged 2 commits intomasterfrom
dan-stowell merged 2 commits intomasterfrom
Conversation
Prep work for bumping the testbazel inner Bazel version to 9, where sh_binary and sh_test are no longer native rules and must be loaded from @rules_shell. - Warm @rules_shell in the prewarmed Bazel 8 install too (it's already always warmed on 9+). This is what lets test-written BUILD files use a single form that works on both versions. - InitModule() now unconditionally adds a bazel_dep on @rules_shell to the inner workspace's MODULE.bazel (if not already present). - Update every test-owned inline BUILD literal under cli/ and enterprise/server/test/integration/ to load sh_binary / sh_test from @rules_shell. No behavior change on Bazel 8 beyond the one extra bazel_dep in tests' inner MODULE.bazel; fully compatible with the upcoming 9.1.0 bump. Co-authored-by: Shelley <shelley@exe.dev>
Co-authored-by: Shelley <shelley@exe.dev>
dan-stowell
requested review from
bduffany,
keith,
maggie-lou,
sluongng and
tempoz
keith
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep work for bumping testbazel's inner Bazel to 9.x, where
sh_binary/sh_testare no longer native rules and must be loaded from@rules_shell. Warms@rules_shellin testbazel's prewarmed Bazel 8 install and updates every test-owned inline BUILD literal to load the rules explicitly, so the same BUILD content works on both Bazel 8 and 9.