Restrict with's first type to be string#124
Closed
thejcannon wants to merge 3 commits intobuildkite:mainfrom
Closed
Restrict with's first type to be string#124thejcannon wants to merge 3 commits intobuildkite:mainfrom
with's first type to be string#124thejcannon wants to merge 3 commits intobuildkite:mainfrom
Conversation
thejcannon
commented
Dec 7, 2024
schema.json
Outdated
Comment on lines
848
to
849
| "type": "string", | ||
| "description": "List of existing or new elements for single-dimension Build Matrix", |
Contributor
Author
There was a problem hiding this comment.
FWIW This kind of smells like a bug in the server-side pipeline validator (that it forces string and doesn't allow int or bool). I tried making the with: value an int and it did error, so this new schema is accurate.
Contributor
|
Closing in favour of #128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following pipeline errors with "Each element in a
matrix.adjustments.withmust be either a hash or a string":