Skip to content

Restrict with's first type to be string #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thejcannon wants to merge 3 commits into from
Closed

Restrict with's first type to be string #124

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d3a892
Update schema.json
thejcannon Dec 7, 2024
2bf51fa
Update schema.json
thejcannon Dec 8, 2024
0d669a5
Update schema.json
thejcannon Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,9 +845,8 @@
"with": {
"oneOf": [
{
"type": "array",
"type": "string",
"description": "List of existing or new elements for single-dimension Build Matrix",
Copy link
Contributor Author

@thejcannon thejcannon Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW This kind of smells like a bug in the server-side pipeline validator (that it forces string and doesn't allow int or bool). I tried making the with: value an int and it did error, so this new schema is accurate.

"items": { "$ref": "#/definitions/matrixElement" }
},
{
"type": "object",
Expand Down