Skip to content

chore: Bump github.com/docker/docker to v28.0.4 and fix broken API#288

Closed
alphanota wants to merge 10 commits intobuildpacks:mainfrom
alphanota:upgrade-docker
Closed

chore: Bump github.com/docker/docker to v28.0.4 and fix broken API#288
alphanota wants to merge 10 commits intobuildpacks:mainfrom
alphanota:upgrade-docker

Conversation

@alphanota
Copy link
Copy Markdown
Contributor

@alphanota alphanota commented Apr 1, 2025

Skaffold (github.com/googlecontainertools/skaffold) depends on imgutil as a dependency. We are trying to update to the latest docker package versions but unfortunately there are some braking changes between v26 and v28. This is my attempt at upgrading docker in imgutil and fixing the broken API.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.89%. Comparing base (7ebe5c6) to head (ae863de).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #288       +/-   ##
===========================================
- Coverage   58.29%   38.89%   -19.39%     
===========================================
  Files          32       36        +4     
  Lines        3694     3294      -400     
===========================================
- Hits         2153     1281      -872     
- Misses       1184     1819      +635     
+ Partials      357      194      -163     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alphanota alphanota changed the title chore:upgrade docker packages to v28 chore: Bump github.com/docker/docker to v28.0.4 and fix broken API Apr 1, 2025
@alphanota
Copy link
Copy Markdown
Contributor Author

Copying @natalieparellano 's comment on the original PR here:

@alphanota thank you for this. We'll need to tread carefully here, as the CNB lifecycle also depends on imgutil, and the last time I tried to bump docker there I ran into compatibility issues with buildkit and kaniko. Unfortunately bumping the buildkit version in kaniko will not be easy as kaniko has fallen into an unmaintained state and that is a whole other story.

We are going to need to do something here, as we can't stay on an old docker version forever. I'll bring this up for discussion at one of our next Working Group meetings.

@pbusko
Copy link
Copy Markdown

pbusko commented May 30, 2025

@natalieparellano @alphanota since Kaniko has a new release which uses github.com/docker/docker v28.1.1+incompatible as a dependency, should this PR be revisited?

@alphanota
Copy link
Copy Markdown
Contributor Author

This PR can be closed now that #290 has upgraded the docker version to v28.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants