Skip to content

fix(browser-mcp): fix download list retrieval and path issues#1753

Merged
ycjcl868 merged 1 commit into
mainfrom
fix/browser-mcp-download
Nov 28, 2025
Merged

fix(browser-mcp): fix download list retrieval and path issues#1753
ycjcl868 merged 1 commit into
mainfrom
fix/browser-mcp-download

Conversation

@skychx
Copy link
Copy Markdown
Collaborator

@skychx skychx commented Nov 27, 2025

  • Fix resourceUri path error
  • Use browser (not page) to create CDPSession: unexpected page closure auto-closes CDPSession, breaking browser download event listening

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 27, 2025

Deploy Preview for agent-tars-docs canceled.

Name Link
🔨 Latest commit 18d6c53
🔍 Latest deploy log https://app.netlify.com/projects/agent-tars-docs/deploys/69280bad32c19800076056a8

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 27, 2025

Deploy Preview for tarko canceled.

Name Link
🔨 Latest commit 18d6c53
🔍 Latest deploy log https://app.netlify.com/projects/tarko/deploys/69280badd82c7b00083a2080

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 14.27%. Comparing base (9896387) to head (18d6c53).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ent-infra/mcp-servers/browser/src/utils/browser.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   14.26%   14.27%   +0.01%     
==========================================
  Files         250      250              
  Lines        8562     8565       +3     
  Branches     1672     1674       +2     
==========================================
+ Hits         1221     1223       +2     
  Misses       7166     7166              
- Partials      175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ycjcl868 ycjcl868 merged commit 258374a into main Nov 28, 2025
13 checks passed
@ycjcl868 ycjcl868 deleted the fix/browser-mcp-download branch November 28, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants