Skip to content

fix(browser-mcp): fix download list retrieval and path issues #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ycjcl868 merged 1 commit into from
Nov 28, 2025
Merged

fix(browser-mcp): fix download list retrieval and path issues #1753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/agent-infra/mcp-servers/browser/src/utils/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import path from 'node:path';
import { Browser, Page } from 'puppeteer-core';
import { LocalBrowser, RemoteBrowser } from '@agent-infra/browser';
import { PuppeteerBlocker } from '@ghostery/adblocker-puppeteer';
Expand Down Expand Up @@ -185,7 +186,7 @@ export async function ensureBrowser() {
}

if (!store.initialBrowserSetDownloadBehavior) {
const client = await store.globalPage.createCDPSession();
const client = await store.globalBrowser.target().createCDPSession();
const { outputDir } = store.globalConfig;
await client.send('Browser.setDownloadBehavior', {
behavior: 'allow',
Expand All @@ -201,7 +202,7 @@ export async function ensureBrowser() {
guid: event.guid,
url: event.url,
suggestedFilename: event.suggestedFilename,
resourceUri: `download://${event.suggestedFilename}`,
resourceUri: path.join(outputDir!, event.suggestedFilename),
createdAt: new Date().toISOString(),
progress: 0,
state: 'inProgress',
Expand Down Expand Up @@ -230,6 +231,14 @@ export async function ensureBrowser() {
`状态: ${event.state}, 已下载: ${event.receivedBytes}/${event.totalBytes}`,
);

if (event.state === 'completed') {
// @ts-ignore
if (event.filePath) {
// @ts-ignore
downloadInfo.resourceUri = event.filePath;
}
}

// canceled from browser
if (event.state === 'canceled') {
store.downloadedFiles.splice(idx, 1);
Expand Down
Loading