Skip to content

fix(situla): support Windows config writes - #254

Open
dajiaohuang wants to merge 1 commit into
bytedance:mainfrom
dajiaohuang:fix/253-situla-windows-config
Open

fix(situla): support Windows config writes#254
dajiaohuang wants to merge 1 commit into
bytedance:mainfrom
dajiaohuang:fix/253-situla-windows-config

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

  • construct Situla's atomic configuration filename with the platform-aware path basename helper
  • avoid asserting POSIX permission bits on Windows while retaining those checks on supported filesystems
  • verify the atomic writer leaves only the final config.json

Fixes #253

Tests

  • npm test (81 passed)
  • npm run typecheck
  • npm run build
  • uvx pre-commit run --show-diff-on-failure --color=never --files python/01-tutorials/04-agentkit-tools/situla/src/config.ts python/01-tutorials/04-agentkit-tools/situla/test/config.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Situla cannot persist configuration on Windows

1 participant