Skip to content

fix(situla): support Windows config writes #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(situla): support Windows config writes #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/01-tutorials/04-agentkit-tools/situla/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
writeFileSync,
} from "node:fs";
import { homedir } from "node:os";
import { dirname, isAbsolute, join } from "node:path";
import { basename, dirname, isAbsolute, join } from "node:path";

export const CONFIG_KEYS = [
"VOLCENGINE_REGION",
Expand Down Expand Up @@ -135,7 +135,7 @@ function readSettingsFile<Key extends string>(
function writeJsonAtomic(path: string, value: Record<string, string>): void {
const temporaryPath = join(
dirname(path),
`.${path.split("/").at(-1)}.${process.pid}.${randomBytes(6).toString("hex")}.tmp`,
`.${basename(path)}.${process.pid}.${randomBytes(6).toString("hex")}.tmp`,
);
writeFileSync(temporaryPath, `${JSON.stringify(value, null, 2)}\n`, { mode: 0o600 });
renameSync(temporaryPath, path);
Expand Down
9 changes: 6 additions & 3 deletions python/01-tutorials/04-agentkit-tools/situla/test/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync, readFileSync, rmSync, statSync, writeFileSync, mkdirSync } from "node:fs";
import { mkdirSync, mkdtempSync, readFileSync, readdirSync, rmSync, statSync, writeFileSync } from "node:fs";
import { join } from "node:path";
import { tmpdir } from "node:os";
import { loadSitulaConfiguration, writeSitulaConfiguration } from "../src/config.ts";
Expand Down Expand Up @@ -31,13 +31,16 @@ test("configuration writer creates one private config file without credentials",
const initial = loadSitulaConfiguration({ XDG_CONFIG_HOME: root });
const values = { ...initial.values, VOLCENGINE_SERVICE: "agentkit_custom", VOLCENGINE_HOST: "agentkit-custom.example.com" };
writeSitulaConfiguration(values, initial.paths);
assert.equal(statSync(initial.paths.directory).mode & 0o777, 0o700);
assert.equal(statSync(initial.paths.config).mode & 0o777, 0o600);
if (process.platform !== "win32") {
assert.equal(statSync(initial.paths.directory).mode & 0o777, 0o700);
assert.equal(statSync(initial.paths.config).mode & 0o777, 0o600);
}
const config = JSON.parse(readFileSync(initial.paths.config, "utf8"));
assert.equal(config.TOOL_TYPE, undefined);
assert.equal(config.VOLCENGINE_SERVICE, "agentkit_custom");
assert.equal(config.VOLCENGINE_ACCESS_KEY, undefined);
assert.equal(config.VOLCENGINE_SESSION_TOKEN, undefined);
assert.deepEqual(readdirSync(initial.paths.directory), ["config.json"]);
});

test("legacy TOOL_TYPE is accepted while reading and removed on the next write", (context) => {
Expand Down