Skip to content

fix: Secure unauthenticated proof status update #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LSUDOKO wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Secure unauthenticated proof status update #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions hardware-web3-service/claimClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,19 @@ class ClaimClient {
constructor() {
this.baseURL = process.env.CLAIM_SERVER_URL || 'https://lensmint.onrender.com';
const timeout = parseInt(process.env.CLAIM_CLIENT_TIMEOUT || '30000', 10);

const headers = {
'Content-Type': 'application/json'
};

if (process.env.API_SECRET) {
headers['Authorization'] = `Bearer ${process.env.API_SECRET}`;
}

this.client = axios.create({
baseURL: this.baseURL,
timeout: timeout,
headers: {
'Content-Type': 'application/json'
}
headers: headers
});
}

Expand Down Expand Up @@ -168,7 +175,7 @@ class ClaimClient {
verification_status,
proof_tx_hash: proof_tx_hash ? `${proof_tx_hash.substring(0, 10)}...` : null
});

const response = await this.client.post('/update-proof-status', {
claim_id,
token_id,
Expand Down
76 changes: 49 additions & 27 deletions lensmint-public-server/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ let servicesInitialized = false;
async function initializeServices() {
try {
console.log('🔄 Initializing claim server services...');

dbService.initialize();
console.log('✅ Database initialized');

Expand All @@ -61,11 +61,33 @@ async function initializeServices() {

initializeServices();

app.post('/create-claim', (req, res) => {
// Middleware to protect internal API routes
const requireAuth = (req, res, next) => {
const apiSecret = process.env.API_SECRET;

if (!apiSecret) {
console.error('⚠️ API_SECRET environment variable is missing.');
return res.status(500).json({ success: false, error: 'Server misconfiguration: missing API_SECRET' });
}

const authHeader = req.headers['authorization'] || req.headers['Authorization'];
if (!authHeader || !authHeader.startsWith('Bearer ')) {
return res.status(401).json({ success: false, error: 'Authentication required' });
}

const token = authHeader.split(' ')[1];
if (token !== apiSecret) {
return res.status(401).json({ success: false, error: 'Invalid authentication token' });
}

next();
};

app.post('/create-claim', requireAuth, (req, res) => {
try {
const {
claim_id,
cid,
const {
claim_id,
cid,
metadata_cid,
device_id,
camera_id,
Expand All @@ -82,9 +104,9 @@ app.post('/create-claim', (req, res) => {
}

const claim = dbService.createClaim(
claim_id,
null,
cid,
claim_id,
null,
cid,
metadata_cid || null,
device_id || null,
camera_id || null,
Expand Down Expand Up @@ -204,13 +226,13 @@ app.get('/api/metadata/:claim_id', (req, res) => {
}
});

app.post('/update-proof-status', (req, res) => {
app.post('/update-proof-status', requireAuth, (req, res) => {
try {
const {
claim_id,
token_id,
verification_status,
proof_tx_hash
const {
claim_id,
token_id,
verification_status,
proof_tx_hash
} = req.body;

if (!claim_id) {
Expand Down Expand Up @@ -243,9 +265,9 @@ app.post('/update-proof-status', (req, res) => {
app.get('/verify/:claim_id', async (req, res) => {
try {
const { claim_id } = req.params;

const claim = dbService.getClaim(claim_id);

if (!claim) {
return res.status(404).send(`
<!DOCTYPE html>
Expand Down Expand Up @@ -294,7 +316,7 @@ app.get('/verify/:claim_id', async (req, res) => {
};

let proofData = dbService.getProof(claim_id);

if (proofData) {
console.log(`[VERIFY] Found proof in local DB: status=${proofData.verification_status}, tx=${proofData.proof_tx_hash || 'none'}`);
} else {
Expand Down Expand Up @@ -759,10 +781,10 @@ app.get('/claim/:claim_id', (req, res) => {
` : ''}

<div id="status" class="status ${claim.status}">
${claim.status === 'open' ? `Status: Open - Ready for editions! Original Token ID: ${claim.token_id || 'N/A'}` :
claim.status === 'claimed' ? `Status: Claimed - Address: ${claim.recipient_address}` :
claim.status === 'completed' ? 'Status: Completed - NFT Minted! 🎉' :
'Status: Pending - Waiting for original NFT to be minted...'}
${claim.status === 'open' ? `Status: Open - Ready for editions! Original Token ID: ${claim.token_id || 'N/A'}` :
claim.status === 'claimed' ? `Status: Claimed - Address: ${claim.recipient_address}` :
claim.status === 'completed' ? 'Status: Completed - NFT Minted! 🎉' :
'Status: Pending - Waiting for original NFT to be minted...'}
</div>

<form id="claimForm" ${claim.status === 'open' ? '' : 'style="display:none;"'}>
Expand Down Expand Up @@ -970,7 +992,7 @@ app.post('/claim/:claim_id/submit', (req, res) => {
}
});

app.post('/update-claim-status', (req, res) => {
app.post('/update-claim-status', requireAuth, (req, res) => {
try {
const { claim_id, status, token_id, tx_hash } = req.body;

Expand Down Expand Up @@ -1007,7 +1029,7 @@ app.post('/update-claim-status', (req, res) => {
}
});

app.post('/create-edition-request', (req, res) => {
app.post('/create-edition-request', requireAuth, (req, res) => {
try {
const { claim_id, wallet_address } = req.body;

Expand Down Expand Up @@ -1058,7 +1080,7 @@ app.post('/create-edition-request', (req, res) => {
}
});

app.get('/get-pending-edition-requests', (req, res) => {
app.get('/get-pending-edition-requests', requireAuth, (req, res) => {
try {
const limit = parseInt(req.query.limit) || 50;
const requests = dbService.getPendingEditionRequests(limit);
Expand All @@ -1077,7 +1099,7 @@ app.get('/get-pending-edition-requests', (req, res) => {
}
});

app.post('/update-edition-request', (req, res) => {
app.post('/update-edition-request', requireAuth, (req, res) => {
try {
const { request_id, status, tx_hash, token_id, error_message } = req.body;

Expand Down Expand Up @@ -1116,7 +1138,7 @@ app.post('/update-edition-request', (req, res) => {
}
});

app.post('/complete-claim', (req, res) => {
app.post('/complete-claim', requireAuth, (req, res) => {
try {
const { claim_id, tx_hash, token_id } = req.body;

Expand Down Expand Up @@ -1161,7 +1183,7 @@ app.get('/health', (req, res) => {

app.listen(PORT, async () => {
await initializeServices();

console.log('═══════════════════════════════════════');
console.log('🎫 LensMint Claim Server');
console.log('═══════════════════════════════════════');
Expand Down