Remove dummy interface for termios#3248
Closed
hovsater wants to merge 2 commits into
Closed
Conversation
Contributor
Author
hovsater
changed the title
hovsater
force-pushed
the
termios-dummy-interface
branch
from
9d9acdb to
a8a7240
Compare
Contributor
Author
|
@ManuLinares and I decided that we'll merge all work into a single PR. See #3254 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix some inconsistencies with the "dummy interface" that's provided by
lib/std/libc/termios.c3. Specifically, it was added in commit b0e104b, but then changes in 487057d and 5b39dc9 forgot to make the necessary changes to that interface as well.With that said, I have some follow up questions:
Termiosstructure is incompatible anyway?