Skip to content

Preserve merged-track OQL groups when submitting queries from Study View#5569

Draft
Copilot wants to merge 3 commits into
masterfrom
copilot/fix-study-view-oql-trackgroups
Draft

Preserve merged-track OQL groups when submitting queries from Study View#5569
Copilot wants to merge 3 commits into
masterfrom
copilot/fix-study-view-oql-trackgroups

Conversation

Copilot AI commented May 11, 2026

Copy link
Copy Markdown
Contributor

Study View accepted merged-track OQL syntax in the input box, but submission rebuilt gene_list from flattened parsed lines, dropping track-group structure/labels before opening Results View. As a result, grouped queries like ["My fav genes" TP53: HOMDEL, BRAF: V600E] were not represented the same way as homepage submissions.

  • Submission path alignment (Study View vs homepage)

    • Added a dedicated serializer for Study View submission that prefers the original typed query string (geneQueryStr) when present.
    • Kept a fallback to parsed-line reconstruction only when the text input is empty.
  • Store integration

    • Updated StudyViewPageStore.onSubmitQuery() to use the new serializer instead of always joining unparseOQLQueryLine(query) output, which flattened merged groups.
  • Regression coverage

    • Added focused specs to ensure merged-track OQL text is preserved verbatim on submission and fallback behavior remains intact.
export function getGeneListForStudyViewSubmission(
    geneQueryStr: string,
    geneQueries: SingleGeneQuery[]
): string {
    const normalizedGeneQueryStr = geneQueryStr.trim();
    if (normalizedGeneQueryStr.length > 0) {
        return normalizedGeneQueryStr;
    }
    return geneQueries.map(query => unparseOQLQueryLine(query)).join('\n');
}

@netlify

netlify Bot commented May 11, 2026

Copy link
Copy Markdown

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 8bc39ab
🔍 Latest deploy log https://app.netlify.com/projects/cbioportalfrontend/deploys/6a023549b55ec00008af0b54
😎 Deploy Preview https://deploy-preview-5569.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI changed the title [WIP] Fix study view to support OQL trackgroups format Preserve merged-track OQL groups when submitting queries from Study View May 11, 2026
Copilot AI requested a review from alisman May 11, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Study View genes input allows OQL, but not OQL trackgroups

2 participants