Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/pages/studyView/StudyViewPageStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ import {
getDefaultClinicalDataBinFilter,
getCustomChartDownloadData,
generateColorMapKey,
getGeneListForStudyViewSubmission,
MutationCategorization,
getChartMetaSet,
getVisibleAttributes,
Expand Down Expand Up @@ -10350,9 +10351,10 @@ export class StudyViewPageStore
let url = '/';
if (!_.isEmpty(this.geneQueries)) {
formOps.Action = 'Submit';
formOps.gene_list = this.geneQueries
.map(query => unparseOQLQueryLine(query))
.join('\n');
formOps.gene_list = getGeneListForStudyViewSubmission(
this.geneQueryStr,
this.geneQueries
);
url = '/results';
}
submitToPage(url, formOps, '_blank');
Expand Down
24 changes: 24 additions & 0 deletions src/pages/studyView/StudyViewUtils.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
getExponent,
getFilteredMolecularProfilesByAlterationType,
getFilteredSampleIdentifiers,
getGeneListForStudyViewSubmission,
getFilteredStudiesWithSamples,
getFrequencyStr,
getGroupedClinicalDataByBins,
Expand Down Expand Up @@ -4846,6 +4847,29 @@ describe('StudyViewUtils', () => {
});
});

describe('getGeneListForStudyViewSubmission', () => {
it('keeps merged-track OQL query text unchanged', () => {
const mergedTrackQuery =
'["My fav genes" TP53: HOMDEL, BRAF: V600E]';
assert.strictEqual(
getGeneListForStudyViewSubmission(mergedTrackQuery, [
{ gene: 'TP53', alterations: [{ alteration_type: 'homdel' }] },
{ gene: 'BRAF', alterations: [{ alteration_type: 'mut' }] },
] as SingleGeneQuery[]),
mergedTrackQuery
);
});

it('falls back to parsed query list when query text is empty', () => {
assert.strictEqual(
getGeneListForStudyViewSubmission('', [
{ gene: 'TP53', alterations: false },
] as SingleGeneQuery[]),
'TP53'
);
});
});

describe('annotationFilterActive', () => {
it('false when all excluded', () => {
assert.isFalse(annotationFilterActive(false, false, false));
Expand Down
16 changes: 15 additions & 1 deletion src/pages/studyView/StudyViewUtils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,10 @@ import {
GenomicDataCountFilter,
GenomicDataFilter,
} from 'cbioportal-ts-api-client/dist/generated/CBioPortalAPIInternal';
import { queryContainsStructVarAlteration } from 'shared/lib/oql/oqlfilter';
import {
queryContainsStructVarAlteration,
unparseOQLQueryLine,
} from 'shared/lib/oql/oqlfilter';
import { toast } from 'react-toastify';
import { useCallback } from 'react';
import { MutationOptionConstants } from 'shared/constants';
Expand Down Expand Up @@ -597,6 +600,17 @@ export function updateGeneQuery(
return updatedQueries;
}

export function getGeneListForStudyViewSubmission(
geneQueryStr: string,
geneQueries: SingleGeneQuery[]
): string {
const normalizedGeneQueryStr = geneQueryStr.trim();
if (normalizedGeneQueryStr.length > 0) {
return normalizedGeneQueryStr;
}
return geneQueries.map(query => unparseOQLQueryLine(query)).join('\n');
}

function translateSpecialText(text: string | undefined): string {
if (!text) {
return '';
Expand Down