fix: commit BEFORE release cmd so we dont deadlock#155
Closed
JacobCoffee wants to merge 1 commit into
Closed
Conversation
Contributor
|
we've been seeing more success with Cabo deploying itself in environments where that's a thing, so closing this until we have signal again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we deploy on a migration that touces the project_appps table (but i guess any table the deploy task touches during session) it deadlocks because we are reading it. this commits then releases all locks BEFORE running relwease cmds so it doesnt lock up