Skip to content

fix: commit BEFORE release cmd so we dont deadlock #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacobCoffee wants to merge 1 commit into from
Closed

fix: commit BEFORE release cmd so we dont deadlock #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cabotage/celery/tasks/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,6 +1130,12 @@ def deploy_release(deployment):
],
),
)
# Commit the session before running release commands (e.g., migrations)
# to release any row/table locks. Without this, migrations that ALTER
# tables read by this task will deadlock — the migration waits for our
# lock, and we wait for the migration to finish.
db.session.commit()
db.session.refresh(deployment)
for release_command in deployment.release_object.release_commands:
deploy_log.append(f"Running release command {release_command}")
job_object = render_job(
Expand Down