Treat 'BUREVER BE1' as FitPlus bike during device discovery - #4568
Open
cagnulein wants to merge 2 commits into
Open
Treat 'BUREVER BE1' as FitPlus bike during device discovery#4568cagnulein wants to merge 2 commits into
cagnulein wants to merge 2 commits into
Conversation
Owner
Author
Owner
Author
|
argh sorry! let me create an ios build for this! i will send you later today |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BUREVER BE1so they are handled as FitPlus bikes during Bluetooth discovery.Description
b.name().toUpper().startsWith("BUREVER BE1")to the conditional that matches FitPlus devices so afitplusbikeinstance is created and initialized in the existing code path.Testing
Codex Task