Skip to content

fix: use 0x31 metrics for Apex WLT8266BM bikes - #4887

Merged
cagnulein merged 2 commits into
masterfrom
fix/apexbike-wlt8266bm-07e2
Aug 5, 2026
Merged

fix: use 0x31 metrics for Apex WLT8266BM bikes#4887
cagnulein merged 2 commits into
masterfrom
fix/apexbike-wlt8266bm-07e2

Conversation

@cagnulein

@cagnulein cagnulein commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Disable the WLT8266BM 0x30 distance-counter parser for the whole family.
  • Keep the standard 0x31 cadence/resistance/distance parsing for these Apex bikes.
  • Update regression coverage for multiple WLT8266BM variants.

Evidence

Issue #4886 includes two logs from WLT8266BM_07E2:

  • During the static phase, 0x30 increments while 0x31 remains ea503100001400000095, indicating zero cadence.
  • During cycling, 0x31 byte 4 changes and produces the expected cadence values.
  • Treating 0x30 as distance creates movement metrics while the bike is not being pedalled.

The fix intentionally prioritizes correct behavior for the user-provided WLT8266BM bike family over the previous unverified 0x30 interpretation for other variants.

Test plan

  • git diff --check
  • Replay of the issue Apex Rides auto transmit/start #4886 log: static phase remains at zero with the 0x31 parser.
  • Added TestApexBikeParser assertions for multiple WLT8266BM variants.

Fixes #4886

@cagnulein cagnulein changed the title fix: use 0x31 metrics for Apex WLT8266BM_07E2 fix: use 0x31 metrics for Apex WLT8266BM bikes Aug 5, 2026
@cagnulein
cagnulein merged commit 0f8f5ec into master Aug 5, 2026
16 of 17 checks passed
@cagnulein
cagnulein deleted the fix/apexbike-wlt8266bm-07e2 branch August 5, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apex Rides auto transmit/start

1 participant