fix: use 0x31 metrics for Apex WLT8266BM bikes - #4887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x30distance-counter parser for the whole family.0x31cadence/resistance/distance parsing for these Apex bikes.Evidence
Issue #4886 includes two logs from
WLT8266BM_07E2:0x30increments while0x31remainsea503100001400000095, indicating zero cadence.0x31byte 4 changes and produces the expected cadence values.0x30as distance creates movement metrics while the bike is not being pedalled.The fix intentionally prioritizes correct behavior for the user-provided WLT8266BM bike family over the previous unverified
0x30interpretation for other variants.Test plan
git diff --check0x31parser.TestApexBikeParserassertions for multiple WLT8266BM variants.Fixes #4886