feat: base plugin repack #29

thymikee · 2024-11-22T02:47:08Z

Summary

Got Metro to work, so had to get base Re.Pack support 🚀.

On top I've added logic to merge package.json files (and adjusted other plugins to follow), repurposed rewritePackageJson to sortDevDepsInPackageJson and added a helper for making dev deps unique in dist package.json.

create-app output	re.pack running

Test plan

Need to add some later

rnef.config.mjs:

import {pluginRepack} from '@callstack/rnef-plugin-repack';
export default {
  plugins: {
    repack: pluginRepack({
      root: __dirname,
      reactNativePath: join(__dirname, './node_modules/react-native'),
      platforms: {android: {}},
    }),
  }
};

szymonrybczak · 2024-11-25T06:45:08Z

managed to run it locally 🔥

packages/plugin-repack/eslint.config.js

mdjastrzebski · 2024-11-25T21:26:38Z

packages/create-app/src/lib/fs.ts

    } else {
-      fs.copyFileSync(srcFile, distFile);
+      // merge package.json files
+      if (nodePath.basename(srcFile) === 'package.json') {


[nit]

would be good to extract to separate function e.g. mergePackageJson.

Should also check for duplicated dep names, if the version is the same, then ok, but in case of mismatch should warn (or try to resolve to common subset?)

Check 83e22d3

mdjastrzebski · 2024-11-26T12:33:22Z

packages/plugin-platform-ios/src/template/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "rnef-plugin-platform-ios-template",
+  "scripts": {


mdjastrzebski · 2024-11-26T12:33:40Z

packages/plugin-platform-ios/src/template/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "rnef-plugin-platform-ios-template",


We can omit name as it's getting ignored anyway

Nx started to weirdly fail without the name, like it would consider this package.json as a project's one. After trying a few things and removing all the caches, I went with this solution.

mdjastrzebski · 2024-11-26T12:35:49Z

packages/create-app/src/lib/fs.ts

+  }
+  const dist = JSON.parse(fs.readFileSync(to, 'utf-8'));
+  dist.scripts = { ...dist.scripts, ...src.scripts };
+  dist.devDependencies = removeDuplicateDependencies({


We can merge also regular deps & peer deps

For now we're not doing this so I opted out. Happy to introduce this logic once necessary.

mdjastrzebski · 2024-11-26T12:36:16Z

packages/create-app/src/lib/fs.ts

+    fs.copyFileSync(from, to);
+  }
+  const dist = JSON.parse(fs.readFileSync(to, 'utf-8'));
+  dist.scripts = { ...dist.scripts, ...src.scripts };


[nit] we should check for script overwrite too

mdjastrzebski · 2024-11-26T12:38:05Z

packages/create-app/src/lib/fs.ts

+    { devDependencies: {} }
+  );
+
+  return {


Warn if there are duplicate deps entries with version mismatch?

szymonrybczak · 2024-11-27T13:49:00Z

packages/plugin-metro/src/lib/pluginMetro.ts

  (api: PluginApi): PluginOutput => {
    api.registerCommand({
-      name: 'dev',
+      name: 'start',


so we're back to React Native convention?

start → for starting development server?

I don't have strong opinions about it. We can change anytime

i guess we wanted to have more web-like experience, but it might create some unpleasant change for rnc cli users, when we proceed it with new convention.

yeah, on the other hand I thought we'd create our own dev server and hook metro/re.pack there and that's apparently not necessary at the moment. happy to revisit that

thymikee force-pushed the feat/plugin-repack branch from 9013470 to 531e8b5 Compare November 22, 2024 15:16

mdjastrzebski reviewed Nov 25, 2024

View reviewed changes

packages/plugin-repack/eslint.config.js Show resolved Hide resolved

thymikee force-pushed the feat/plugin-repack branch from 097224b to ad48ebf Compare November 25, 2024 18:34

mdjastrzebski reviewed Nov 25, 2024

View reviewed changes

thymikee mentioned this pull request Nov 26, 2024

fix: set cliFile in Gradle to point to RNEF instead of RNC CLI #31

Merged

mdjastrzebski reviewed Nov 26, 2024

View reviewed changes

szymonrybczak reviewed Nov 27, 2024

View reviewed changes

thymikee mentioned this pull request Nov 28, 2024

chore: fix build issue #34

Merged

thymikee force-pushed the feat/plugin-repack branch from f0f312b to a370651 Compare November 28, 2024 18:04

This was referenced Nov 29, 2024

chore: verdaccio setup #35

Merged

Feat/create in existing project #37

Closed

thymikee added 14 commits December 2, 2024 13:54

feat: base plugin repack

fa39259

fix tests

878341c

include plugins in generated rnef.config

0c30f61

update necessary options

13eec89

fix lint

d33a67a

fix: update rspack to make android release source maps work

eabd21b

feat: merge package.jsons in all plugins, sort deps

f4d18ff

fix eslint

6fb459a

make remove duplicates generic and apply to scripts

13f1e0c

merge scripts and deps with destructuring, todo warning

5674f35

add importName

170b451

update tests

512b2dc

change latest to actual package versions in templates

d984189

add self to template deps for plugin-repack and metro

a6ef811

thymikee added 4 commits December 2, 2024 13:55

update contributing and package exports

fa8d91b

update contributing guide

7b45ad5

fix lint

2861884

skip tests that's fixed in #35

abc3e4f

thymikee force-pushed the feat/plugin-repack branch from c4d38eb to abc3e4f Compare December 2, 2024 12:55

thymikee merged commit 7679c8a into main Dec 2, 2024
1 check passed

thymikee deleted the feat/plugin-repack branch December 2, 2024 13:07

LiChuanZhu mentioned this pull request Oct 14, 2025

There is a bug in the gradlew assembleRelease #540

Closed

		@@ -0,0 +1,9 @@
		{
		"name": "rnef-plugin-platform-ios-template",

feat: base plugin repack #29

feat: base plugin repack #29

Uh oh!

Conversation

thymikee commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

szymonrybczak commented Nov 25, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thymikee commented Nov 22, 2024 •

edited

Loading