chore: verdaccio setup #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thymikee merged 42 commits into main from chore/verdaccio-setup

Dec 12, 2024

Collaborator

mdjastrzebski commented Nov 29, 2024 •

edited

Loading

Summary

Scope:

Verdaccio setup script (scripts/verdaccio-start.mjs)
Make e2e tests pass locally
Run Verdaccio on CI
Make e2e tests pass on CI
Modify create-app to use NPM-based templates
Fix template composition for NPM-based templates

Test plan

thymikee reviewed

View reviewed changes

packages/cli/package.json Outdated Show resolved Hide resolved

thymikee reviewed

View reviewed changes

packages/create-app/package.json Show resolved Hide resolved

thymikee reviewed

View reviewed changes

scripts/verdaccio.yaml Outdated Show resolved Hide resolved

thymikee reviewed

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

thymikee reviewed

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

thymikee added a commit that referenced this pull request


          skip tests that's fixed in #35

c4d38eb

thymikee reviewed

View reviewed changes

packages/create-app/e2e/e2e.test.ts Show resolved Hide resolved

szymonrybczak reviewed

View reviewed changes

packages/create-app/e2e/e2e.test.ts Outdated

    
              const CREATE_APP_PATH = path.resolve(__dirname, '../dist/src/bin.js');

              const TEMPLATES_DIR = path.resolve(__dirname, '../../../templates');

              const REGISTRY_URL = 'http://localhost:4873/';

Collaborator

szymonrybczak Dec 2, 2024

how about doing something like this?

https://github.com/react-native-community/cli/blob/1f91b6d9e656f3c5d36228862bc2b380e7771313/packages/cli/src/tools/npm.ts#L13-L27

Collaborator Author

mdjastrzebski Dec 9, 2024

not sure what would be the benefits here. I would probably keep the current setup and refactor it if benefitial in the future

thymikee added a commit that referenced this pull request


          skip tests that's fixed in #35

abc3e4f

thymikee added a commit that referenced this pull request


          feat: base plugin repack (#29)

7679c8a

* feat: base plugin repack

* fix tests

* include plugins in generated rnef.config

* update necessary options

* fix lint

* fix: update rspack to make android release source maps work

* feat: merge package.jsons in all plugins, sort deps

* fix eslint

* make remove duplicates generic and apply to scripts

* merge scripts and deps with destructuring, todo warning

* add importName

* update tests

* change latest to actual package versions in templates

* add self to template deps for plugin-repack and metro

* update contributing and package exports

* update contributing guide

* fix lint

* skip tests that's fixed in #35

mdjastrzebski force-pushed the chore/verdaccio-setup branch from 07522c7 to 008fd80 Compare

December 2, 2024 14:56

mdjastrzebski added 7 commits

December 9, 2024 09:50


          chore: setup verdaccio

630d4f1

tweaks

chore: verdaccio setup

chore: verdaccio setup

chore: tweaks

fix ci

fix

fix

fix

fix

fix local e2e

debug

fix

fix


          fix typecheck

df2d8ce


          debug

408a242

fix

da90f32

fix

3087bd7


          disable tests

4a8eb1a


          debug

06bb1c3

mdjastrzebski force-pushed the chore/verdaccio-setup branch from b7a1dad to 06bb1c3 Compare

December 9, 2024 08:50

mdjastrzebski added 2 commits

December 9, 2024 13:10


          publish template package

6d38792


          fix merging of NPM-based templates

12b5b07

thymikee reviewed

View reviewed changes

packages/create-app/src/lib/edit-template.ts Outdated Show resolved Hide resolved


          cleanup

6be43f4

mdjastrzebski changed the title ~~chore: verdaccio setup (WIP)~~ chore: verdaccio setup

mdjastrzebski added 6 commits

December 9, 2024 19:02


          remove publishConfig

b7466f1

fix

3dcb1e4


          move verdaccio config

af0ea29


          remove sleep

d2ea83f

fix

c1779bf


          restore sleep

783cf0c

mdjastrzebski added 9 commits

December 10, 2024 13:45


          code review: limit create app steps

faca3bf


          replaceAll

9a314c1


          packageJson field removal

d6a169b


          improve verdaccio startup script

0b5cf38


          chore tweaks

494e4c2


          improve verdaccio init script

5b13a75


          simplify verdaccio config

812e100


          pnpm lock

e21033f


          swap execa for nano-spawn

8d6f9b1

thymikee reviewed

View reviewed changes

scripts/verdaccio-init.mjs Outdated Show resolved Hide resolved

mdjastrzebski added 4 commits

December 10, 2024 17:01


          handle also sigterm


          backup file

a860acf


          more tweaks

0eb6f0c


          run verdaccio in bg on ci

3e757cb

szymonrybczak reviewed

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

mdjastrzebski added 3 commits

December 11, 2024 12:27


          fix help

53aeeb1


          use npm publish instead of pnpm publish

aa964d5


          fix issue with removed +x flag on gradlew

7c46343

thymikee reviewed

View reviewed changes

packages/create-app/package.json Outdated Show resolved Hide resolved

mdjastrzebski and others added 7 commits

December 12, 2024 11:14

fix

d4fe2b0


          fix pnpm install

f5ea026


          improve ci stability

e3cf3dc


          docs

76c8e82


          fix typo

d084842


          refactor: cleanup template handling in packages (#47)

d69d232

* move template dirs

* fix output package structure

* remove: *.md from nx/tsc assets (advised by jbroma)

* remove dist/package.json after build


          fix package.json resolution in cli

ecefea0

thymikee approved these changes

View reviewed changes

thymikee merged commit dcb5656 into main

1 check passed

thymikee deleted the chore/verdaccio-setup branch

December 12, 2024 14:27

LiChuanZhu mentioned this pull request

There is a bug in the gradlew assembleRelease #540

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet