Skip to content

chore: verdaccio setup #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Dec 12, 2024
Merged

chore: verdaccio setup #35

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
630d4f1
chore: setup verdaccio
mdjastrzebski Nov 28, 2024
df2d8ce
fix typecheck
mdjastrzebski Dec 2, 2024
408a242
debug
mdjastrzebski Dec 2, 2024
da90f32
fix
mdjastrzebski Dec 2, 2024
3087bd7
fix
mdjastrzebski Dec 2, 2024
4a8eb1a
disable tests
mdjastrzebski Dec 2, 2024
06bb1c3
debug
mdjastrzebski Dec 2, 2024
6d38792
publish template package
mdjastrzebski Dec 9, 2024
12b5b07
fix merging of NPM-based templates
mdjastrzebski Dec 9, 2024
6be43f4
cleanup
mdjastrzebski Dec 9, 2024
b7466f1
remove `publishConfig`
mdjastrzebski Dec 9, 2024
3dcb1e4
fix
mdjastrzebski Dec 9, 2024
af0ea29
move verdaccio config
mdjastrzebski Dec 9, 2024
d2ea83f
remove sleep
mdjastrzebski Dec 9, 2024
c1779bf
fix
mdjastrzebski Dec 9, 2024
783cf0c
restore sleep
mdjastrzebski Dec 9, 2024
13ef307
tweaks
mdjastrzebski Dec 9, 2024
53b4503
more tweaks
mdjastrzebski Dec 9, 2024
9988b96
code review changes
mdjastrzebski Dec 10, 2024
faca3bf
code review: limit create app steps
mdjastrzebski Dec 10, 2024
9a314c1
replaceAll
mdjastrzebski Dec 10, 2024
d6a169b
packageJson field removal
mdjastrzebski Dec 10, 2024
0b5cf38
improve verdaccio startup script
mdjastrzebski Dec 10, 2024
494e4c2
chore tweaks
mdjastrzebski Dec 10, 2024
5b13a75
improve verdaccio init script
mdjastrzebski Dec 10, 2024
812e100
simplify verdaccio config
mdjastrzebski Dec 10, 2024
e21033f
pnpm lock
mdjastrzebski Dec 10, 2024
8d6f9b1
swap execa for nano-spawn
mdjastrzebski Dec 10, 2024
6721846
handle also sigterm
mdjastrzebski Dec 10, 2024
a860acf
backup file
mdjastrzebski Dec 10, 2024
0eb6f0c
more tweaks
mdjastrzebski Dec 10, 2024
3e757cb
run verdaccio in bg on ci
mdjastrzebski Dec 10, 2024
53aeeb1
fix help
mdjastrzebski Dec 11, 2024
aa964d5
use npm publish instead of pnpm publish
mdjastrzebski Dec 11, 2024
7c46343
fix issue with removed +x flag on gradlew
mdjastrzebski Dec 12, 2024
d4fe2b0
fix
mdjastrzebski Dec 12, 2024
f5ea026
fix pnpm install
mdjastrzebski Dec 12, 2024
e3cf3dc
improve ci stability
mdjastrzebski Dec 12, 2024
76c8e82
docs
mdjastrzebski Dec 12, 2024
d084842
fix typo
thymikee Dec 12, 2024
d69d232
refactor: cleanup template handling in packages (#47)
mdjastrzebski Dec 12, 2024
ecefea0
fix package.json resolution in cli
mdjastrzebski Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ pnpm e2e

# Or Create RNEF app
NPM_CONFIG_REGISTRY=http://localhost:4873 pnpm create @callstack/rnef-app --registry http://localhost:4873
# Then use pnpn install with registry
NPM_CONFIG_REGISTRY=http://localhost:4873 pnpm install

# Clean up
pnpm verdaccio-reset
Copy link
Contributor

@thymikee thymikee Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also intercept kill singal (e.g. ctrl+c) in scripts/verdaccio-init.mjs and call this cleanup as well?

Copy link
Collaborator Author

@mdjastrzebski mdjastrzebski Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a good idea, will check

Copy link
Collaborator Author

@mdjastrzebski mdjastrzebski Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done for SIGINT & SIGTERM. SIGKILL cannot be captured.

Expand Down
7 changes: 5 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@
"bin": {
"rnef": "./dist/src/bin.js"
},
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@callstack/rnef-config": "workspace:*",
"@callstack/rnef-tools": "workspace:*",
"@callstack/rnef-config": "^0.0.1",
"@callstack/rnef-tools": "^0.0.1",
"@clack/prompts": "^0.8.1",
"@react-native-community/cli-config": "^15.1.2",
"commander": "^12.1.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"types": "./dist/src/index.d.ts",
"import": "./dist/src/index.js"
},
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"tslib": "^2.3.0"
}
Expand Down
5 changes: 3 additions & 2 deletions packages/create-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@
"dist"
],
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc",
"e2e": "vitest --config vite.e2e.config.js"
},
"bin": {
"create-rnef-app": "./dist/src/bin.js"
},
"dependencies": {
"@callstack/rnef-tools": "workspace:*",
"@callstack/rnef-tools": "^0.0.1",
"@clack/prompts": "^0.8.1",
"gradient-string": "^3.0.0",
"minimist": "^1.2.8",
Expand All @@ -25,7 +26,7 @@
"tslib": "^2.3.0"
},
"devDependencies": {
"@callstack/rnef-test-helpers": "workspace:*",
"@callstack/rnef-test-helpers": "w^0.0.1",
"@types/gradient-string": "^1.1.6",
"@types/minimist": "^1.2.5"
}
Expand Down
7 changes: 5 additions & 2 deletions packages/plugin-metro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@
"dist",
"src"
],
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@callstack/rnef-tools": "workspace:*",
"@callstack/rnef-tools": "^0.0.1",
"@react-native-community/cli-server-api": "^15.1.2",
"@react-native/community-cli-plugin": "^0.76.0",
"tslib": "^2.3.0"
},
"devDependencies": {
"@callstack/rnef-config": "workspace:*"
"@callstack/rnef-config": "^0.0.1"
}
}
7 changes: 5 additions & 2 deletions packages/plugin-platform-android/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@
"dist",
"src"
],
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@callstack/rnef-tools": "workspace:*",
"@callstack/rnef-tools": "^0.0.1",
"@clack/prompts": "^0.8.1",
"@react-native-community/cli-config-android": "^15.1.2",
"chalk": "^5.3.0",
Expand All @@ -20,7 +23,7 @@
"tslib": "^2.3.0"
},
"devDependencies": {
"@callstack/rnef-config": "workspace:*",
"@callstack/rnef-config": "^0.0.1",
"@react-native-community/cli-types": "^15.1.2"
}
}
17 changes: 13 additions & 4 deletions packages/plugin-platform-apple/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,19 @@
"name": "@callstack/rnef-plugin-platform-apple",
"version": "0.0.1",
"type": "module",
"main": "./dist/src/index.js",
"typings": "./dist/src/index.d.ts",
"exports": {
"types": "./dist/src/index.d.ts",
"import": "./dist/src/index.js"
},
"files": [
"dist",
"src"
],
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@callstack/rnef-tools": "workspace:*",
"@callstack/rnef-tools": "^0.0.1",
"@clack/prompts": "^0.7.0",
"@react-native-community/cli-config-apple": "^15.1.2",
"fast-glob": "^3.3.2",
Expand All @@ -15,6 +24,6 @@
"tslib": "^2.3.0"
},
"devDependencies": {
"@callstack/rnef-config": "workspace:*"
"@callstack/rnef-config": "^0.0.1"
}
}
7 changes: 5 additions & 2 deletions packages/plugin-platform-ios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@
"dist",
"src"
],
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@react-native-community/cli-config-apple": "^15.1.2",
"tslib": "^2.3.0",
"@callstack/rnef-plugin-platform-apple": "workspace:*"
"@callstack/rnef-plugin-platform-apple": "^0.0.1"
},
"devDependencies": {
"@callstack/rnef-config": "workspace:*"
"@callstack/rnef-config": "^0.0.1"
}
}
7 changes: 5 additions & 2 deletions packages/plugin-repack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@
"types": "./dist/src/index.d.ts",
"import": "./dist/src/index.js"
},
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@callstack/rnef-tools": "workspace:*",
"@callstack/rnef-tools": "^0.0.1",
"tslib": "^2.3.0"
},
"devDependencies": {
"@callstack/rnef-config": "workspace:*"
"@callstack/rnef-config": "^0.0.1"
},
"peerDependencies": {
"@callstack/repack": "5.0.0-rc.2",
Expand Down
3 changes: 3 additions & 0 deletions packages/tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"types": "./dist/src/index.d.ts",
"import": "./dist/src/index.js"
},
"scripts": {
"publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
},
"dependencies": {
"@clack/prompts": "^0.8.1",
"@expo/fingerprint": "^0.11.2",
Expand Down
16 changes: 8 additions & 8 deletions scripts/verdaccio-init.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@ async function removeAllPackages() {

async function publishPackages() {
log.step('Publishing all packages to Verdaccio...');
await spawn('pnpm', [
'-r',
'publish',
'--registry',
VERDACCIO_REGISTRY_URL,
'--no-git-checks',
'--force',
]);

// This is a workaround to make pnpm publish work with our templates.
// PNPM removes execute (+x) flag from files in package, e.g. gradlew, so
// we use `npm publish` instead of `pnpm publish` to publish packages.
// This also prevents us from using `workspace:` dependencies.
// This is a known issue: https://github.com/pnpm/pnpm/issues/8862
await spawn('pnpm', ['-r', 'publish:verdaccio']);

log.step('Published all packages.');
}

Expand Down
Loading