Skip to content

Conversation

@szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Sep 6, 2025

Summary

Uses more generic fs-fingerprint to unlock more platforms support without hacks and better performance.

Closes #510
Closes #309

This also shaves almost 300 kB off the create-app package, and few MB if we upgraded to latest fingerprint version 😮

Screenshot 2025-09-08 at 19 32 17 Screenshot 2025-09-08 at 19 33 07 Screenshot 2025-09-08 at 19 32 21

Test plan

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2025

🦋 Changeset detected

Latest commit: bfb347c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@rock-js/platform-apple-helpers Patch
@rock-js/platform-android Patch
@rock-js/config Patch
@rock-js/tools Patch
rock Patch
rock-docs Patch
@rock-js/platform-ios Patch
@rock-js/plugin-brownfield-android Patch
@rock-js/plugin-brownfield-ios Patch
@rock-js/plugin-metro Patch
@rock-js/plugin-repack Patch
@rock-js/provider-github Patch
@rock-js/provider-s3 Patch
@rock-js/test-helpers Patch
@rock-js/welcome-screen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rock Ignored Ignored Preview Sep 10, 2025 7:22pm

@thymikee
Copy link
Contributor

thymikee commented Sep 7, 2025

Added env support, so it supersedes #510

@thymikee thymikee marked this pull request as ready for review September 7, 2025 07:48
@thymikee thymikee force-pushed the feat/use-fs-fingerprint branch from 393165b to aa80c66 Compare September 8, 2025 18:15
@thymikee thymikee merged commit 88f18d4 into main Sep 10, 2025
5 checks passed
@thymikee thymikee deleted the feat/use-fs-fingerprint branch September 10, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Take env variable into account for fingerprint

3 participants