Skip to content

Include camundaBuiltins for feel rule#206

Merged
Buckwich merged 1 commit intomainfrom
3983_get-or-else
Jul 23, 2025
Merged

Include camundaBuiltins for feel rule#206
Buckwich merged 1 commit intomainfrom
3983_get-or-else

Conversation

@Buckwich
Copy link
Member

@Buckwich Buckwich commented Jul 9, 2025 •
edited
Loading

Related to camunda/camunda-modeler#3983

Proposed Changes

Include camundaBuiltins for feel rule

Try out

npx @bpmn-io/sr camunda/linting -l camunda/bpmnlint-plugin-camunda-compat#3983_get-or-else

try using camunda extensions (eg get or else())

image

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 9, 2025
@Buckwich Buckwich changed the title 3983_get-or-else Include camundaBuiltins for feel rule Jul 9, 2025
@Buckwich Buckwich force-pushed the 3983_get-or-else branch from 9148f1f to 9549958 Compare July 9, 2025 08:52
@Buckwich Buckwich mentioned this pull request Jul 9, 2025
Merged
4 tasks
@Buckwich Buckwich added the ready Ready to be worked on label Jul 14, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the in progress Currently worked on label Jul 14, 2025
@Buckwich Buckwich mentioned this pull request Jul 18, 2025
Closed
11 tasks
@Buckwich Buckwich mentioned this pull request Jul 21, 2025
Closed
4 tasks
@Buckwich Buckwich marked this pull request as ready for review July 21, 2025 15:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Jul 21, 2025
@Buckwich Buckwich mentioned this pull request Jul 21, 2025
Merged
4 tasks
@Buckwich Buckwich requested review from barmac and nikku July 21, 2025 15:14
barmac
barmac reviewed Jul 22, 2025
View reviewed changes
@barmac barmac marked this pull request as draft July 22, 2025 11:03
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jul 22, 2025
@Buckwich Buckwich added the ready Ready to be worked on label Jul 22, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the in progress Currently worked on label Jul 22, 2025
nikku
nikku approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👏

@Buckwich Buckwich marked this pull request as ready for review July 23, 2025 14:46
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Jul 23, 2025
@Buckwich
Copy link
Member Author

Buckwich commented Jul 23, 2025 •
edited
Loading

I noticed a bit too many changes for my liking in the package-lock.json

image

adjusted it to keep it minimal: https://github.com/camunda/bpmnlint-plugin-camunda-compat/compare/a96f4892701d3f8eb5e407117701ac4eb84d8563..dd49d2beb81a191069eeeff62e1d0cbd5bacb019

now:
image

@Buckwich Buckwich merged commit 4b8ef76 into main Jul 23, 2025
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 23, 2025
@Buckwich Buckwich deleted the 3983_get-or-else branch July 23, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barmac barmac barmac left review comments

@nikku nikku nikku approved these changes

Assignees

@Buckwich Buckwich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Buckwich @nikku @barmac