Skip to content

Migrate camunda builtins from feel-editor to seperate repo#1

Merged
Buckwich merged 2 commits intomainfrom
migrate
Jul 21, 2025
Merged

Migrate camunda builtins from feel-editor to seperate repo#1
Buckwich merged 2 commits intomainfrom
migrate

Conversation

@Buckwich
Copy link
Member

@Buckwich Buckwich commented Jul 8, 2025

Related to camunda/camunda-modeler#3983

Proposed Changes

Migration of camundaBuiltins into separate repo.

As this PR is just exporting a list of variables, nothing much to try out (or even test) here. But you can checkout camunda/bpmnlint-plugin-camunda-compat#206 to see how it integrates

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@Buckwich Buckwich added the in progress Currently worked on label Jul 8, 2025
@Buckwich Buckwich self-assigned this Jul 8, 2025
@Buckwich Buckwich marked this pull request as ready for review July 8, 2025 14:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 8, 2025
@Buckwich Buckwich marked this pull request as draft July 8, 2025 14:01
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jul 8, 2025
@Buckwich Buckwich changed the title Migrate Migrate camunda builtins from feel-editor to seperate repo Jul 8, 2025
@Buckwich Buckwich force-pushed the migrate branch 2 times, most recently from 2bb6c52 to 95f36af Compare July 9, 2025 08:38
@Buckwich Buckwich marked this pull request as ready for review July 9, 2025 08:56
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 9, 2025
@Buckwich Buckwich requested a review from Copilot July 9, 2025 09:05

This comment was marked as outdated.

@Buckwich Buckwich requested review from a team, barmac and jarekdanielak and removed request for a team July 9, 2025 09:09
Copy link

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs a cleanup, cf. the comments.

I'd suggest to squash the commits from bpmn-io/feel-editor as we won't benefit from them in this project.

@Buckwich Buckwich added the in progress Currently worked on label Jul 18, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the needs review Review pending label Jul 18, 2025
@Buckwich Buckwich force-pushed the migrate branch 4 times, most recently from 7414a77 to 2a9ad9a Compare July 18, 2025 14:14
@Buckwich Buckwich requested a review from nikku July 18, 2025 15:32
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 18, 2025
@Buckwich Buckwich requested a review from Copilot July 18, 2025 15:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates Camunda FEEL builtins from the feel-editor repository to a separate, dedicated repository. The migration establishes a standalone package that can be consumed by various tools that need Camunda FEEL extensions.

  • Introduces build automation to extract builtins from Camunda documentation
  • Creates a comprehensive test suite for the parsing and compilation functionality
  • Sets up package infrastructure with proper exports, CI/CD, and documentation

Reviewed Changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
package.json Configures the new package with build scripts, dependencies, and module exports
lib/index.js Main entry point exporting camundaBuiltins
lib/camundaBuiltins.js Generated file containing 1700+ lines of compiled builtin functions
tasks/compileBuiltins.js Build script that processes Markdown docs and generates the builtins file
tasks/utils/parseBuiltins.js Utility functions for parsing function signatures from documentation
test/spec/lib/camundaBuiltins.spec.js Integration tests verifying the exported builtins structure
test/spec/tasks/utils/parseBuiltins.spec.js Unit tests for the parsing utility functions
Comments suppressed due to low confidence (1)

test/spec/lib/camundaBuiltins.spec.js:5

  • The describe block name 'lib/compileBuiltins' is inconsistent with what is being tested. This should be 'lib/camundaBuiltins' to match the actual module being tested.
describe('lib/compileBuiltins', function() {

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Buckwich as I understood the intend of this PR is to make this library ready to release.

Find attached some updates that I'd like us to merge/incorporate if possible:

  • drop boost (I don't know why this should be in scope of this library), it is not documented (a651c43)
  • ensure we test the types we ship (081483c), but also as we're on it, validate the code base :)
  • ensure the eslint configuration validates our code base (9ae2d92)
  • A CI task that ensures we recognize when new built-ins arrive - ce77184
  • Improved test coverage of the actual "thing" (b2d400f) and dropping some legacy that is no longer needed (b10df10)
    The code base is now linted, and type checked, and should be good to release. Please have a look at my additions to the PR.

@nikku
Copy link
Member

nikku commented Jul 21, 2025

Consider what you want to incorporate; I'm happy to spin off, i.e. the CI changes to a separate PR.

@nikku
Copy link
Member

nikku commented Jul 21, 2025

I've just realized you worked on "automatic update" of the built-ins via #2. I'd be interested how you evaluate automatic update vs. "knowing new built-ins are there".

@Buckwich
Copy link
Member Author

FYI: I'll wait to merge this PR until I also have the auto update CI done. I'll use the chinese comma fix to test that, but want that fix included in the first release

Buckwich and others added 2 commits July 21, 2025 15:17
@Buckwich
Copy link
Member Author

Buckwich commented Jul 21, 2025

@Buckwich Buckwich merged commit d933e1c into main Jul 21, 2025
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 21, 2025
@Buckwich Buckwich deleted the migrate branch July 21, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants