-
Notifications
You must be signed in to change notification settings - Fork 148
feat: add data migration for 8.8 #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
charts/camunda-platform-8.8/templates/orchestration/data-migration-configmap.yaml
Outdated
Show resolved
Hide resolved
| migration: | ||
| process: | ||
| ## @param orchestration.migration.process.enabled if true, the process migration occurs. | ||
| data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this nesting be removed? It might be confusing, since the property would be CAMUNDA_MIGRATION_PROCESS_* whereas in the values it would be CAMUNDA_MIGRATION_DATA_PROCESS_*. Or is that something that we are doing in other places as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values.yaml does not conform to the application config so it is okay for the values.yaml to have a different structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the main goals of having Helm is to have an abstraction layer on top of the application to not worry about the application config.
charts/camunda-platform-8.8/templates/orchestration/data-migration-configmap.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-8.8/templates/orchestration/data-migration-configmap.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-8.8/templates/orchestration/data-migration-job.yaml
Show resolved
Hide resolved
aabouzaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 🙌
Which problem does the PR fix?
related: https://github.com/camunda/team-distribution/issues/415
What's in this PR?
The data migration includes the following migrations:
NOTE:
This feature is not tested. It is not possible to test this feature currently since 8.8-SNAPSHOT is in the process of being created.
context: https://camunda.slack.com/archives/C07UA4C7STY/p1756965922109239?thread_ts=1756918699.759809&cid=C07UA4C7STY
We will have to wait for the image to be available. For this reason, a new issue has been created on the QA side to test out this feature: https://github.com/camunda/product-hub/issues/3002
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: