Skip to content

Conversation

@hamza-m-masood
Copy link
Contributor

@hamza-m-masood hamza-m-masood commented Sep 4, 2025

Which problem does the PR fix?

related: https://github.com/camunda/team-distribution/issues/415

What's in this PR?

The data migration includes the following migrations:

  • process
  • metrics
  • tu-metrics
  • tasks

NOTE:
This feature is not tested. It is not possible to test this feature currently since 8.8-SNAPSHOT is in the process of being created.
context: https://camunda.slack.com/archives/C07UA4C7STY/p1756965922109239?thread_ts=1756918699.759809&cid=C07UA4C7STY

We will have to wait for the image to be available. For this reason, a new issue has been created on the QA side to test out this feature: https://github.com/camunda/product-hub/issues/3002

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.8 Camunda applications/cycle version component/orchestration labels Sep 4, 2025
@hamza-m-masood hamza-m-masood marked this pull request as ready for review September 4, 2025 13:01
@hamza-m-masood hamza-m-masood requested a review from a team as a code owner September 4, 2025 13:01
migration:
process:
## @param orchestration.migration.process.enabled if true, the process migration occurs.
data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this nesting be removed? It might be confusing, since the property would be CAMUNDA_MIGRATION_PROCESS_* whereas in the values it would be CAMUNDA_MIGRATION_DATA_PROCESS_*. Or is that something that we are doing in other places as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values.yaml does not conform to the application config so it is okay for the values.yaml to have a different structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the main goals of having Helm is to have an abstraction layer on top of the application to not worry about the application config.

@aabouzaid aabouzaid removed the request for review from a team September 5, 2025 15:23
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙌

@hamza-m-masood hamza-m-masood enabled auto-merge (squash) September 5, 2025 16:18
@hamza-m-masood hamza-m-masood merged commit 6272139 into main Sep 5, 2025
9 of 14 checks passed
@hamza-m-masood hamza-m-masood deleted the data-migration branch September 5, 2025 16:41
@github-actions github-actions bot added the version:13.0.0-alpha8 Issues and PRs related to chart version 13.0.0-alpha8 label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/orchestration version/8.8 Camunda applications/cycle version version:13.0.0-alpha8 Issues and PRs related to chart version 13.0.0-alpha8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants