-
Notifications
You must be signed in to change notification settings - Fork 148
feat: add data migration for 8.8 #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
00a9959
feat: add data migration for 8.8
hamza-m-masood e652467
change job to use data migration instead of process migration
hamza-m-masood 7bdd583
importerFinishedTimeout
hamza-m-masood 7e776e3
importerFinishedTimeout
hamza-m-masood ff22d25
rename files
hamza-m-masood b98dfe3
remove hardcoding
hamza-m-masood 11e6458
secrets refactor
hamza-m-masood 619dbbb
migration-data-configmap
hamza-m-masood 40430f1
Merge branch 'main' into data-migration
hamza-m-masood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
64 changes: 64 additions & 0 deletions
64
charts/camunda-platform-8.8/templates/orchestration/migration-data-configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| {{- if .Values.orchestration.migration.data.enabled }} | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "orchestration.fullname" . }}-data-migration-configuration | ||
| data: | ||
| application.yaml: | | ||
| {{- if .Values.global.elasticsearch.enabled }} | ||
| camunda: | ||
| database: | ||
| connect: | ||
| cluster-name: {{ .Values.global.elasticsearch.clusterName }} | ||
| cluster-type: elasticsearch | ||
| url: {{ include "camundaPlatform.elasticsearchURL" . | quote }} | ||
| {{- if and .Values.global.elasticsearch.auth.username .Values.global.elasticsearch.auth.password }} | ||
| username: {{ .Values.global.elasticsearch.auth.username }} | ||
| password: ${VALUES_ELASTICSEARCH_PASSWORD:} | ||
| {{- end }} | ||
| {{- else }} | ||
| camunda: | ||
| database: | ||
| connect: | ||
| cluster-name: {{ .Values.global.opensearch.clusterName }} | ||
| cluster-type: opensearch | ||
| url: {{ include "camundaPlatform.opensearchURL" . | quote }} | ||
| {{- if and .Values.global.opensearch.auth.username .Values.global.opensearch.auth.password }} | ||
| username: {{ .Values.global.opensearch.auth.username }} | ||
| password: ${VALUES_OPENSEARCH_PASSWORD:} | ||
| {{- end }} | ||
| {{- end }} | ||
| migration: | ||
| process: | ||
| batch-size: {{ .Values.orchestration.migration.data.process.batchSize }} | ||
| import-finished-timeout: {{ .Values.orchestration.migration.data.process.importerFinishedTimeout }} | ||
| retry: | ||
| max-retries: {{ .Values.orchestration.migration.data.process.retry.maxRetries }} | ||
| max-retry-delay: {{ .Values.orchestration.migration.data.process.retry.maxRetryDelay }} | ||
| min-retry-delay: {{ .Values.orchestration.migration.data.process.retry.minRetryDelay }} | ||
| retry-delay-multiplier: {{ .Values.orchestration.migration.data.process.retry.retryDelayMultiplier }} | ||
| metrics: | ||
| batch-size: {{ .Values.orchestration.migration.data.metrics.batchSize }} | ||
| import-finished-timeout: {{ .Values.orchestration.migration.data.metrics.importerFinishedTimeout }} | ||
| retry: | ||
| max-retries: {{ .Values.orchestration.migration.data.metrics.retry.maxRetries }} | ||
| max-retry-delay: {{ .Values.orchestration.migration.data.metrics.retry.maxRetryDelay }} | ||
| min-retry-delay: {{ .Values.orchestration.migration.data.metrics.retry.minRetryDelay }} | ||
| retry-delay-multiplier: {{ .Values.orchestration.migration.data.metrics.retry.retryDelayMultiplier }} | ||
| tumetrics: | ||
| batch-size: {{ .Values.orchestration.migration.data.tumetrics.batchSize }} | ||
| import-finished-timeout: {{ .Values.orchestration.migration.data.tumetrics.importerFinishedTimeout }} | ||
| retry: | ||
| max-retries: {{ .Values.orchestration.migration.data.tumetrics.retry.maxRetries }} | ||
| max-retry-delay: {{ .Values.orchestration.migration.data.tumetrics.retry.maxRetryDelay }} | ||
| min-retry-delay: {{ .Values.orchestration.migration.data.tumetrics.retry.minRetryDelay }} | ||
| retry-delay-multiplier: {{ .Values.orchestration.migration.data.tumetrics.retry.retryDelayMultiplier }} | ||
| tasks: | ||
| batch-size: {{ .Values.orchestration.migration.data.tasks.batchSize }} | ||
| import-finished-timeout: {{ .Values.orchestration.migration.data.process.importerFinishedTimeout }} | ||
| retry: | ||
| max-retries: {{ .Values.orchestration.migration.data.process.retry.maxRetries }} | ||
| max-retry-delay: {{ .Values.orchestration.migration.data.process.retry.maxRetryDelay }} | ||
| min-retry-delay: {{ .Values.orchestration.migration.data.process.retry.minRetryDelay }} | ||
| retry-delay-multiplier: {{ .Values.orchestration.migration.data.process.retry.retryDelayMultiplier }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
43 changes: 0 additions & 43 deletions
43
charts/camunda-platform-8.8/templates/orchestration/process-migration-configmap.yaml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this nesting be removed? It might be confusing, since the property would be
CAMUNDA_MIGRATION_PROCESS_*whereas in the values it would beCAMUNDA_MIGRATION_DATA_PROCESS_*. Or is that something that we are doing in other places as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values.yaml does not conform to the application config so it is okay for the values.yaml to have a different structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the main goals of having Helm is to have an abstraction layer on top of the application to not worry about the application config.