fix: wrong openshift compatibilty helper elasticsearch commonLabels usage

[bkenez]

Which problem does the PR fix?

Closes: #4146

What's in this PR?

Added condition to only run the OpenShift elasticsearch compatibility logic when elasticsearch.enabled: true. When elasticsearch is disabled, there's no need for volumeClaimTemplate compatibility and no elasticsearch resources to apply labels to.

Changes
Modified template condition from {{- if eq .Values.global.compatibility.openshift.adaptSecurityContext "force" -}}
To: {{- if and (eq .Values.global.compatibility.openshift.adaptSecurityContext "force") .Values.elasticsearch.enabled -}}
Fixes the template error without adding unnecessary fields to values.yaml.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

• In the repo's root dir, run make go.update-golden-only.
• There is no other open pull request for the same update/change.
• Tests for charts are added (if needed).
• In-repo documentation are updated (if needed).

After opening the PR:

• Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
• Did all checks/tests pass in the PR?

[hamza-m-masood]

I see what you mean here, but this extra check is not really necessary because if elasticsearch is disabled, it won't cause an error in the first place.

Have you encountered any error?

I will still approve if you wish to merge, but again I don't see it as necessary.

[bkenez]

I see what you mean here, but this extra check is not really necessary because if elasticsearch is disabled, it won't cause an error in the first place.

Have you encountered any error?

I will still approve if you wish to merge, but again I don't see it as necessary.

It's just to be extra defensive to better protect it for future cases (if any), it shouldn't cause any issues I think 🤔