chore: run pre-commit on all files #1474
Conversation
|
P.S. pre-commit also reports a few unused |
|
Indeed the trailing spaces in test were significant. |
|
Definitely seems problematic that running pre-commit with our config can break our tests |
dimaqq
force-pushed
the
chore-run-pre-commit
branch
from
87b9e82 to
f0ff476
Compare
dimaqq
force-pushed
the
chore-run-pre-commit
branch
from
f0ff476 to
ea6f6cf
Compare
|
Apparently trialing whitespace fixer doesn't understand Python multiline string literals. Re: RUF039, I think we should probably go through the half dozen instances where ruff insists on raw strings and update tests, wdyt? |
| @@ -1810,7 +1810,7 @@ def test_breakpoint_good_names(self, request: pytest.FixtureRequest, name: str): | |||
| '-', | |||
| '...foo', | |||
| 'foo.bar', | |||
| 'bar--' 'FOO', | |||
| 'bar--FOO', | |||
There was a problem hiding this comment.
I wonder if this was a bug, perhaps 'bar--', 'FOO' was meant?
There was a problem hiding this comment.
I think so, looking at the original commit. Nice find!
|
I'll redo this from scratch at a later date. |
Possibly simplest to review commit by commit. This bumps the versions of the pre-commit tools. A few small issues are also fixed (this is somewhat a subset of #1474, skipping all the docs and controversial changes). * A few strings are formatted more cleanly (including where previous tooling has put in `" "` breaks). * A fix to a framework test (found in #1474). * A fix to a Harness test. * Removing shebangs in Scenario code (none of the files are executable).
Apparently pre-commit was not run on a few occasions and here's the diff.
I'm not sure about dangling whitespace in the pebble test.