tests: Revert "tests: disable second special character case for prompting integration tests" - #16931
Merged
olivercalder merged 1 commit intoMay 8, 2026
Conversation
github-actions
Bot
added
the
Run only one system
olivercalder
changed the title
|
Thu May 7 22:00:43 UTC 2026 Failures:Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Member
Author
|
Once canonical/prompting-client#306 lands, this should work again. |
olivercalder
force-pushed
the
prompting-escape-prompt-path-followup
branch
from
April 24, 2026 03:09
ec6bd83 to
7d62430
Compare
olivercalder
marked this pull request as ready for review
April 24, 2026 03:09
github-actions
Bot
removed
the
Run only one system
olivercalder
marked this pull request as draft
April 24, 2026 03:10
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16931 +/- ##
==========================================
- Coverage 79.13% 79.12% -0.01%
==========================================
Files 1369 1366 -3
Lines 191354 191344 -10
Branches 2465 2465
==========================================
- Hits 151421 151401 -20
- Misses 30826 30833 +7
- Partials 9107 9110 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
canonical/prompting-client#306 landed since the last run, retrying now. If it passes, this can be marked as ready for review. |
Member
Author
|
Right, we need to wait until the |
Member
Author
|
canonical/prompting-client#306 landed and the |
olivercalder
marked this pull request as ready for review
May 4, 2026 19:49
olivercalder
force-pushed
the
prompting-escape-prompt-path-followup
branch
from
May 4, 2026 19:51
7d62430 to
529ee2e
Compare
olivercalder
force-pushed
the
prompting-escape-prompt-path-followup
branch
from
May 5, 2026 22:07
529ee2e to
c3892d5
Compare
olivercalder
added
the
Auto rerun spread
…ting integration tests" The second prompt in the sequence was being parsed incorrectly by the scripted prompting-client, causing it to expect a prompt with the incorrect interface. canonical/prompting-client#306 resolved this issue and the test case can now be re-enabled This reverts commit a6225d3. Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
olivercalder
force-pushed
the
prompting-escape-prompt-path-followup
branch
from
May 7, 2026 20:36
c3892d5 to
a911c14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #16854 which re-enables the second
special_characterstest case for theapparmor-prompting-integration-testsspread test.This is blocked until canonical/prompting-client#305 is resolved.
This work is tracked internally by: https://warthogs.atlassian.net/browse/SNAPDENG-36784