Skip to content

many: inline constant to fix govet error - #17021

Merged
miguelpires merged 1 commit into
canonical:masterfrom
miguelpires:fix-go-vet-2
May 5, 2026
Merged

many: inline constant to fix govet error#17021
miguelpires merged 1 commit into
canonical:masterfrom
miguelpires:fix-go-vet-2

Conversation

@miguelpires

Copy link
Copy Markdown
Contributor

Fix some issues reported by govet

metautil/type_conversions.go:100:18: inline: Constant reflect.Ptr should be inlined (govet)
store/details_v2_test.go:493:41: inline: Constant reflect.Ptr should be inlined (govet)
store/details_v2_test.go:495:11: inline: Constant reflect.Ptr should be inlined (govet)
testutil/base.go:94:33: inline: Constant reflect.Ptr should be inlined (govet)

4 issues:
* govet: 4

Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
@miguelpires miguelpires added the Skip spread Indicate that spread job should not run label May 5, 2026

@Mohit-Chachada Mohit-Chachada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Tue May 5 11:31:11 UTC 2026

Spread tests skipped

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.04%. Comparing base (6ef8a8e) to head (15aed04).

Files with missing lines Patch % Lines
testutil/base.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17021   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files        1375     1371    -4     
  Lines      191012   190928   -84     
  Branches     2465     2465           
=======================================
- Hits       150981   150924   -57     
+ Misses      30924    30904   -20     
+ Partials     9107     9100    -7     
Flag Coverage Δ
unittests 79.04% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bboozzoo bboozzoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelpires
miguelpires merged commit 7508fe4 into canonical:master May 5, 2026
115 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip spread Indicate that spread job should not run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants