Skip to content

interfaces/apparmor: allow reading of /proc/self/smaps_rollup - #17395

Merged
pedronis merged 1 commit into
canonical:masterfrom
bboozzoo:bboozzoo/smaps-rollup
Jul 23, 2026
Merged

interfaces/apparmor: allow reading of /proc/self/smaps_rollup#17395
pedronis merged 1 commit into
canonical:masterfrom
bboozzoo:bboozzoo/smaps-rollup

Conversation

@bboozzoo

Copy link
Copy Markdown
Contributor

Allow read of /proc/self/smaps_rollup.

Related: SNAPDENG-37261, LP#2110510

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

Allow read of /proc/self/smaps_rollup.

Related: SNAPDENG-37261, LP#2110510

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@bboozzoo bboozzoo added Simple 😃 A small PR which can be reviewed quickly Needs security review Can only be merged once security gave a :+1: labels Jul 22, 2026
@bboozzoo bboozzoo added this to the 2.77 milestone Jul 22, 2026

@jslarraz jslarraz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndyer

ndyer commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This probably also fixes nextcloud-snap/nextcloud-snap#2695

@bboozzoo bboozzoo added the Auto rerun spread Auto reruns spread up to 4 times in non-draft PRs w/ >=1 approval and <20 fails in any fund. system label Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Thu Jul 23 13:52:05 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/29992656807

Failures:

Preparing:

  • openstack:opensuse-tumbleweed-64:
  • openstack-arm:ubuntu-24.04-arm-64:tests/main/snap-seccomp-blocks-certain-creat
  • openstack-arm:ubuntu-24.04-arm-64:tests/main/snap-seccomp-blocks-certain-mknod
  • openstack:ubuntu-26.04-64:tests/main/interfaces-posix-mq
  • openstack:ubuntu-24.04-64:tests/main/nvidia-files:535_server
  • openstack:ubuntu-24.04-64:tests/main/nvidia-files:535
  • openstack:ubuntu-22.04-64:tests/main/nvidia-files:535_server
  • openstack:ubuntu-22.04-64:tests/main/nvidia-files:535
  • openstack:ubuntu-24.04-64:tests/main/nvidia-files:535
  • openstack:ubuntu-24.04-64:tests/main/nvidia-files:535_server

Executing:

  • openstack:centos-9-64:tests/main/selinux-clean
  • openstack:centos-9-64:tests/main/selinux-lxd
  • openstack:fedora-44-64:tests/main/selinux-clean
  • openstack:fedora-44-64:tests/main/cgroup-devices-v2
  • openstack:fedora-44-64:tests/main/selinux-lxd
  • openstack:opensuse-tumbleweed-64:tests/main/manpages
  • openstack:ubuntu-26.04-64:tests/main/bad-interfaces-warn
  • openstack:ubuntu-26.04-64:tests/main/auto-refresh-pre-download:close_mid_restart
  • openstack:ubuntu-26.04-64:tests/main/auto-refresh-pre-download:close
  • openstack:ubuntu-26.04-64:tests/main/broken-seeding
  • openstack:ubuntu-26.04-64:tests/main/auto-refresh-pre-download:ignore
  • openstack:ubuntu-26.04-64:tests/main/auto-refresh-pre-download:restart
  • openstack:ubuntu-26.04-64:tests/main/snap-user-service
  • openstack:ubuntu-22.04-64:tests/main/lxd-mount-units

Restoring:

  • openstack:opensuse-tumbleweed-64:

Skipped tests from snapd-testing-skip

If you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)

  • garden:ubuntu-25.10-64:tests/main/apparmor-prompting-support
  • openstack-arm:ubuntu-24.04-arm-64:tests/main/i18n
  • openstack-arm:ubuntu-core-24-arm-64:tests/main/i18n
  • openstack:debian-sid-64:tests/main/interfaces-network-status-classic
  • openstack:debian-sid-64:tests/main/interfaces-xdg-portal-permission-store
  • openstack:ubuntu-24.04-64:tests/main/i18n
  • openstack:ubuntu-25.10-64:tests/main/apparmor-prompting-flag-restart
  • openstack:ubuntu-25.10-64:tests/main/apparmor-prompting-integration-tests
  • openstack:ubuntu-25.10-64:tests/main/apparmor-prompting-prompt-restoration
  • openstack:ubuntu-25.10-64:tests/main/apparmor-prompting-smoke
  • openstack:ubuntu-25.10-64:tests/main/apparmor-prompting-snapd-startup
  • openstack:ubuntu-25.10-64:tests/main/apparmor-prompting-support
  • openstack:ubuntu-25.10-64:tests/main/interfaces-requests-activates-handlers
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-flag-restart
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-integration-tests
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-prompt-restoration
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-smoke
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-snapd-startup
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-support
  • openstack:ubuntu-26.04-64:tests/main/i18n
  • openstack:ubuntu-26.04-64:tests/main/interfaces-requests-activates-handlers

@bboozzoo bboozzoo added the cross-distro Runs all spread systems in parallel label Jul 23, 2026
@bboozzoo bboozzoo closed this Jul 23, 2026
@bboozzoo bboozzoo reopened this Jul 23, 2026
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.86%. Comparing base (8bbab2e) to head (4590793).
⚠️ Report is 54 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17395   +/-   ##
=======================================
  Coverage   78.85%   78.86%           
=======================================
  Files        1404     1402    -2     
  Lines      196234   196239    +5     
  Branches     2466     2462    -4     
=======================================
+ Hits       154748   154770   +22     
+ Misses      32191    32186    -5     
+ Partials     9295     9283   -12     
Flag Coverage Δ
unittests 78.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedronis
pedronis merged commit bc3f673 into canonical:master Jul 23, 2026
599 of 629 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto rerun spread Auto reruns spread up to 4 times in non-draft PRs w/ >=1 approval and <20 fails in any fund. system cross-distro Runs all spread systems in parallel Simple 😃 A small PR which can be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants