fix(button): omit href when disabled to avoid invalid <button href>#2948
Merged
fix(button): omit href when disabled to avoid invalid <button href>#2948
href when disabled to avoid invalid <button href>#2948Conversation
metonym
force-pushed
the
metonym/strip-href-disabled-button
branch
from
99a1f0e to
2b99ebc
Compare
metonym
force-pushed
the
metonym/strip-href-disabled-button
branch
from
2b99ebc to
4b570ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both
hrefanddisabledare passed, the anchor branch is skipped andbuttonProps.hrefwould spread onto<button>, producing invalid HTML.Mirror the existing
typeternary to drophrefifdisabledis true.