feat(open stackblitz): API Key modal #7365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…litz-title-and-saving
…litz-title-and-saving
…litz-title-and-saving
…litz-title-and-saving
…litz-title-and-saving
…litz-title-and-saving
…thub.com/sangeethababu9223/ibm-products into feat/open-in-stackblitz-title-and-saving
…thub.com/sangeethababu9223/ibm-products into feat/open-in-stackblitz-title-and-saving
…thub.com/sangeethababu9223/ibm-products into feat/open-stackblitz-modals
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7365 +/- ##
=======================================
Coverage 84.45% 84.45%
=======================================
Files 425 425
Lines 17229 17229
Branches 4563 4563
=======================================
Hits 14550 14550
Misses 2679 2679
🚀 New features to boost your workflow:
|
matthewgallo
requested changes
May 7, 2025
…eethababu9223/ibm-products into feat/open-stackblitz-modals
CodePreviewer updated to add Storybook style to the |
amal-k-joy
requested changes
May 15, 2025
packages/ibm-products/src/components/OptionsTile/OptionsTile.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| function detectReactHooks(sanitizedCode: string): string[] { | ||
| const hooksToCheck = [ | ||
| 'useState', |
There was a problem hiding this comment.
We might want to expand this a bit further but for most stories these should cover all the bases.
| ${formattedArgs} | ||
| ${hasArgs ? formattedArgs : ''} | ||
| const pkg = { | ||
| prefix: 'c4p' |
There was a problem hiding this comment.
We can import the prefix from package-settings, but I think it's fine to update later.
Merged
via the queue into
carbon-design-system:main
with commit May 19, 2025
03290ec
33 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7347
Implement Open in stackblitz for Modal Components
What did you change?
stackblitzPrefillConfigfunction as string array)storybook-styles.scssto the stackblitz example.scssfile.How did you test and verify your work?
yarn storybook
Note: This PR should only be merged after #7256
Carbon react components passed as props to other components should be passed as custom imports. Eg:
InlineLoadingin APIKeyModal