Skip to content

fix(percy): add global waitForSelector to validate that storybook has loaded #7483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025
Merged

fix(percy): add global waitForSelector to validate that storybook has loaded #7483

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de4a733
fix(percy): increase network timeout value
matthewgallo May 9, 2025
c5057c1
fix: lower timeout to max allowed value
matthewgallo May 9, 2025
1fe1ba2
refactor: wait for sb to load before taking snapshot
matthewgallo May 15, 2025
4a3fc0e
fix: percy waitForSelector needs to be string
matthewgallo May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .percy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ snapshot:
- 1366
minHeight: 1024
discovery:
network_idle_timeout: 500
network_idle_timeout: 750
storybook:
waitForTimeout: 1000
# waits for data-carbon-theme attribute to exist before taking snapshot
# if storybook is still loading, percy could take a snapshot of the storybook
# loading spinner and cause flaky tests
waitForSelector: '[data-carbon-theme]'
include: ['/IBM Products/']
exclude: [
'/Internal/',
Expand Down
Loading