fix(percy): add global waitForSelector to validate that storybook has loaded
#7483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewgallo
requested review from
AlexanderMelox and
jlongshore
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7483 +/- ##
==========================================
- Coverage 83.94% 83.93% -0.02%
==========================================
Files 425 425
Lines 17216 17227 +11
Branches 4545 4553 +8
==========================================
+ Hits 14452 14459 +7
- Misses 2764 2768 +4
🚀 New features to boost your workflow:
|
davidmenendez
previously approved these changes
May 9, 2025
elycheea
previously approved these changes
May 13, 2025
matthewgallo
changed the title
waitForSelector to validate that storybook has loaded
davidmenendez
approved these changes
May 15, 2025
elycheea
approved these changes
May 15, 2025
|
@matthewgallo I’ll let you do the honors but looks like Percy is passing this time. 🙏 |
Merged
via the queue into
carbon-design-system:main
with commit May 15, 2025
ce6686c
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7513
I'm hoping increasing the network timeout for percy will resolve some of the flaky snapshots that get flagged as visual changes.Next attempt is to use the
waitForSelectorin the percy config to look for[data-carbon-theme]since that attribute is only added after storybook has finished loading.Percy has flagged 8 visual differences which I think may be accurate. This PR contained changes to the breadcrumb row height which would explain the page header snapshots. And the other snapshot that was flagged was
NotificationPanel, but it was just the 'n months ago' text. I'll approve the Percy snapshot changes and we can monitor new PRs for any Percy flakiness.While storybook is loading (no
[data-carbon-theme]attribute)After storybook has loaded
What did you change?
.percy.ymlHow did you test and verify your work?
Will test via percy PR check run in this PR