-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying cli to be compatible with api. #9
Conversation
CAS-1945 CLI to match web functionality.
Bringing the CLI up to date with current functionality. The APIs have slightly changed because of projects. rick let's coordinate on this, I can take make sure the server-side is working. Functionality Must-have These already exist or need to be slightly updated because of new APIs
More to-do [ted]
Packaging
Marketing
More IdeasWhat are other onboarding things?
|
cased/cli.py
Outdated
@@ -27,6 +27,8 @@ def cli(): | |||
cli.add_command(logout) | |||
cli.add_command(deployments) | |||
cli.add_command(branches) | |||
cli.add_command(projects) | |||
cli.add_command(targets) | |||
|
|||
# ... (keep the login and setup_target commands as they were) ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# ... (keep the login and setup_target commands as they were) ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol should ask this LLM to not generate those comments
@@ -73,17 +74,17 @@ def build() -> None: | |||
|
|||
project_name = get_repo_name() | |||
secrets = extract_secrets_from_workflow(workflow_content) | |||
create_secrets(project_name, secrets) | |||
CasedAPI().create_secrets(project_name, secrets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts about exporting the empty constructor form of this as just cased_api
? cc @ivan-cased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have cased_api = CasedAI()
in another file, so is can be imported as cased_api
. Not a big deal either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah could be, may choose to do that in the branch_deploy PR, wanting to organize the error messages from api a bit and determine the final structure, right now we sys.exit on non 200 response, that's not a good way to implement or debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🚢🚢🚢🚢
Great work making it happen.
This changes
login
,logout
,projects
,branches
,targets
anddeployments
cased deploy
is split into another PR to make it more readable.Complete example:
