-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying cli to be compatible with api. #9
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ env/ | |
venv/ | ||
.DS_STORE | ||
.pre-commit-config.yaml | ||
.pem |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,8 @@ | |
from rich.panel import Panel | ||
from rich.progress import Progress, SpinnerColumn, TextColumn | ||
|
||
from cased.utils.api import API_BASE_URL, create_secrets | ||
from cased.utils.api import CasedAPI | ||
from cased.utils.constants import CasedConstants | ||
from cased.utils.git import get_repo_name | ||
|
||
console = Console() | ||
|
@@ -73,17 +74,17 @@ def build() -> None: | |
|
||
project_name = get_repo_name() | ||
secrets = extract_secrets_from_workflow(workflow_content) | ||
create_secrets(project_name, secrets) | ||
CasedAPI().create_secrets(project_name, secrets) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thoughts about exporting the empty constructor form of this as just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what do you mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yeah could be, may choose to do that in the branch_deploy PR, wanting to organize the error messages from api a bit and determine the final structure, right now we sys.exit on non 200 response, that's not a good way to implement or debug. |
||
|
||
console.print( | ||
Panel( | ||
f""" | ||
[bold green]GitHub Actions workflow generated successfully![/bold green] | ||
[bold green]Please complete the following steps for the workflow to work correctly: [/bold green] | ||
1. Review the generated workflow file in .github/workflows/deploy.yaml | ||
2. Go to {API_BASE_URL}/secrets/{project_name} to update the secrets. | ||
2. Go to {CasedConstants.API_BASE_URL}/secrets/{project_name} to update the secrets. | ||
3. Commit the changes to your repository, and the workflow will be triggered. | ||
4. Go to {API_BASE_URL}/deployments/ to monitor the deployment status. | ||
4. Go to {CasedConstants.API_BASE_URL}/deployments/ to monitor the deployment status. | ||
""", # noqa: E501 | ||
title="Success", | ||
expand=False, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol should ask this LLM to not generate those comments