Bump Misk & add audit client #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
commented
Apr 1, 2025
| eventSource = "backfila", | ||
| eventTarget = "ChickenSandwich", | ||
| timestampSent = 2147483647, | ||
| applicationName = "deep-fryer", |
There was a problem hiding this comment.
@mpawliszyn can you double check all these values are as expected?
adrw
force-pushed
the
2025-04-01.auditCilent
branch
3 times, most recently
from
7ebb0e5 to
407f205
Compare
|
Waiting on help to fix Vitess changes |
mpawliszyn
reviewed
Apr 4, 2025
| @@ -77,6 +78,7 @@ dependencies { | |||
|
|
|||
| testImplementation(libs.miskTesting) | |||
| testImplementation(libs.miskHibernateTesting) | |||
| testImplementation(testFixtures(libs.miskAuditClient)) | |||
| override fun runCompleted(id: Id<DbBackfillRun>) { | ||
| val (backfillName, run, description) = transacter.transaction { session -> | ||
| val run = session.load<DbBackfillRun>(id) | ||
| Triple(run.registered_backfill.name, run, "Backfill completed ${dryRunPrefix(run)}${nameAndId(run)}") |
There was a problem hiding this comment.
Probably just create a local data class?
There was a problem hiding this comment.
At first I thought this was the backfill description.
There was a problem hiding this comment.
Then we also won't be letting Db objects escape the session.
Misk 2025.04.01.184033-1915641
adrw
force-pushed
the
2025-04-01.auditCilent
branch
from
a6edc27 to
9e4623f
Compare
adrw
force-pushed
the
2025-04-01.auditCilent
branch
from
5261a39 to
c301320
Compare
seanprashad
approved these changes
Apr 4, 2025
mpawliszyn
reviewed
Apr 4, 2025
|
|
||
| private data class AuditEvent( | ||
| val backfillName: String, | ||
| val run: DbBackfillRun, |
There was a problem hiding this comment.
The point is not to have the Db object?
adrw
force-pushed
the
2025-04-01.auditCilent
branch
from
b1b17d7 to
df18b61
Compare
mpawliszyn
approved these changes
Apr 4, 2025
adrw
force-pushed
the
2025-04-01.auditCilent
branch
9 times, most recently
from
1199a2f to
3963044
Compare
adrw
force-pushed
the
2025-04-01.auditCilent
branch
from
3963044 to
8dbac6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misk 2025.04.01.184033-1915641