Merged
Conversation
jeancochrane
reviewed
Jun 2, 2025
Member
jeancochrane
left a comment
jeancochrane
left a comment
There was a problem hiding this comment.
One critical change! Re-request me once it's in and I can give a quick final approval.
| uses: ccao-data/actions/.github/workflows/build-and-run-batch-job.yaml@main | ||
| with: | ||
| ref: Add-parameter-to-build-and-run-model-res-workflow-to-run-ingest-on-Batch | ||
| command: ${{ needs.parse-command.outputs.command }} |
Member
There was a problem hiding this comment.
[Nitpick, required] This is likely why you had to unfreeze ingest to run this logic in the workflow -- without the command key, the reusable build-and-run-batch-job workflow will always fall back to the default (empty string), which will mean that the bash logic that decides whether to override the container command will never return an override. So basically, without command, repro_ingest will always be a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to point back to the main branch
#380
Workflow to test
https://us-east-1.console.aws.amazon.com/cloudwatch/home?region=us-east-1#logsV2:log-groups/log-group/%2Faws%2Fbatch%2Fjob/log-events/z_ci_tidy-up-model-run-pr_ccao-data-model-res-avm%2Fdefault%2F451b4108c4a14d61822bee98d3a0ba37