Skip to content

Tidy up build and run model pr #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Damonamajor merged 7 commits into from
Jun 3, 2025
Merged

Tidy up build and run model pr #382

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5314ec4
Update build-and-run-model.yaml
Damonamajor Jun 2, 2025
e0fe47f
remove a param
Damonamajor Jun 2, 2025
0de54ca
unfreeze ingest
Damonamajor Jun 2, 2025
94c73ac
Revert changes
Damonamajor Jun 2, 2025
ef63477
quick revert for another run
Damonamajor Jun 2, 2025
1b1e1b8
revert again
Damonamajor Jun 2, 2025
a727c1e
Update build-and-run-model.yaml
Damonamajor Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/build-and-run-model.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,8 @@ jobs:
# required in order to allow the reusable called workflow to push to
# GitHub Container Registry
packages: write
uses: ccao-data/actions/.github/workflows/build-and-run-batch-job.yaml@Add-parameter-to-build-and-run-model-res-workflow-to-run-ingest-on-Batch
uses: ccao-data/actions/.github/workflows/build-and-run-batch-job.yaml@main
with:
ref: Add-parameter-to-build-and-run-model-res-workflow-to-run-ingest-on-Batch
command: ${{ needs.parse-command.outputs.command }}
Copy link
Member

@jeancochrane jeancochrane Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nitpick, required] This is likely why you had to unfreeze ingest to run this logic in the workflow -- without the command key, the reusable build-and-run-batch-job workflow will always fall back to the default (empty string), which will mean that the bash logic that decides whether to override the container command will never return an override. So basically, without command, repro_ingest will always be a no-op.

backend: "ec2"
vcpu: "40"
memory: "158000"
Expand Down
Loading