Fix command/entrypoint mapping to match Docker semantics - #127
Merged
Conversation
command was mapped to ContainerSpec.Command (ENTRYPOINT) instead of ContainerSpec.Args (CMD). This broke images with entrypoints like cloudflare/cloudflared where command: ["tunnel", "run", ...] would try to execute "tunnel" as a binary instead of passing it as args to the cloudflared entrypoint.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandwas mapped toContainerSpec.Command(ENTRYPOINT override) instead ofContainerSpec.Args(CMD)entrypointfield existed in the schema but was never wired upcloudflare/cloudflared) wherecommand: ["tunnel", "run", ...]tried to executetunnelas a binaryChanges
commandtoContainerSpec.ArgsandentrypointtoContainerSpec.Commandentrypointto the example swarm-app.ymlTest plan